Repository navigation
fix: skip French locale test when locale unavailable (#1213) - #1219
Merged
vspinu merged 1 commit intoJun 15, 2026
Merged
Conversation
Add skip_if guard and on.exit cleanup to 'parsing months with dots works in French linux locale' test, matching the existing pattern in the 'parsing with r and R formats works in non-english locale' test below it. Without this, the test errors on systems where fr_FR.utf8 is not installed.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Test "parsing months with dots works in French linux locale" (
test-parsers.R:1121) errors on systems wherefr_FR.utf8is not installed:Fix
Added
skip_ifguard andon.exitcleanup, matching the existing pattern in the adjacent test "parsing with r and R formats works in non-english locale" (line 1143):Testing
testthat::test_file("tests/testthat/test-parsers.R")— all tests passskip_on_os("mac")(pre-existing)skip_if(the fix)Closes #1213