Repository navigation
Rate limit improvements - #99
Merged
Merged
Conversation
Extend `RateLimit` with a `units` parameter (default `1`) so one dispatch can consume multiple tokens from a shared bucket. `slotParams` now scales `intervalMs` by `units`, and values are clamped to at least 1 to avoid invalid configuration. Expanded tests cover pure `slotParams` behavior (base interval, scaling, key stability, clamping, per-key buckets) and an integration scenario proving a high-unit dispatch advances the shared bucket cursor by multiple slots.
Refactors `RateLimit` into its own file and extends it with `.keyed(...)` factories that derive per-entity keys from typed input via closures or KeyPaths. Enqueue paths now resolve dynamic keys while typed input is still available (`StrandClient` and `WorkflowContext`) before encoding/scheduling. Slot-key behavior was also clarified for `sharedKey` + `key` composition, and tests were expanded to cover dynamic key extraction, shared bucket partitioning, no-op resolution, and end-to-end per-entity bucket timing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
improved rate limit options
Changes
Testing
swift testpasses locallyAI Disclosure
Tool(s) used:
Extent of use:
Was the PR description itself AI-generated?