Repository navigation
Update Rust Cargo Dependencies for Soroban Contracts Security Advisories - #407
Merged
Merged
Conversation
|
@sourirashmi2004 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@sourirashmi2004 is attempting to deploy a commit to the thisisouvik's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #344 Update Rust Cargo Dependencies for Soroban Contracts Security Advisories
serde_with (#93): KeyValueMap serialization panics on empty sequence or map entries.
stellar-xdr (#45): StringM::from_str bypasses maximum length validation.
soroban-env-host (#46): Muxed address <-> ScVal conversions may break after conversion failure.
rand (#47): Unsoundness with custom logger using rand::rng().
Upgrading the Rust workspace dependencies under contracts/ will ensure contract build tools, test suites, and cryptographic types match the latest secure Soroban SDK releases.
Acceptance Criteria
Run cargo update in the contracts/ directory to bump serde_with, stellar-xdr, soroban-env-host, and rand to patched versions compatible with the current Rust toolchain.
Run cargo test across all Soroban contract crates (lending, treasury, auto_compound_vault, etc.) to ensure all test snapshots and contract executions pass.
Commit updated contracts/Cargo.lock.
Verify Dependabot alerts #93, #45, #46, and #47 resolve upon merge.