Skip to content

fix(quality): remove ts-nocheck directives and eliminate cascading render warnings (#134) - #146

Merged
thisisouvik merged 2 commits into
thisisouvik:mainfrom
SUMAN967-GHOSH:fix/issue-134-type-safety-lint-cleanup
Oct 18, 2026
Merged

thisisouvik merged 2 commits into
thisisouvik:mainfrom
SUMAN967-GHOSH:fix/issue-134-type-safety-lint-cleanup

Conversation

@SUMAN967-GHOSH

Copy link
Copy Markdown
Contributor

Closes #134

Summary of Changes

  • Removed // @ts-nocheck\ directives:
    • \ rontend/src/app/account/AccountClient.tsx\
    • \ rontend/src/app/rules/RulesClient.tsx\
    • \ rontend/src/app/vault/page.tsx\
    • \�ackend/src/routes/vault.ts\
    • \�ackend/src/engine/processor.ts\
  • Eliminated cascading render warnings (
    eact-hooks/set-state-in-effect\)
    :
    • Refactored \AccountClient.tsx\ data fetching to a clean, un-cascaded asynchronous effect pattern with mount tracking.
    • Eliminated synchronous \setState\ calls during mount in \WithdrawModal\ and vault page loading in \ rontend/src/app/vault/page.tsx.
  • Cleaned up unused variables and imports:
    • Removed unused imports \DollarSign\ and \ArrowUpRight\ in \AccountClient.tsx.
    • Removed unused icons \Pause, \Play, \DollarSign, \Calendar, and \CheckCircle2\ in \RulesClient.tsx.
    • Removed unused
      uleAssetOf\ and properly passed \ ransactions\ into \calcETA\ with \EtaResult\ return type in \GoalsClient.tsx.
    • Removed unused vault deposit/withdraw helper imports in \�ackend/src/routes/vault.ts.
    • Defined \SupportedAsset, \parseAssetCode, and explicit interface return types in \�ackend/src/engine/processor.ts.
  • Escaped unescaped entities in JSX:
    • Formatted unescaped apostrophes (') in \ChatClient.tsx\ and \GoalsClient.tsx.

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@SUMAN967-GHOSH is attempting to deploy a commit to the thisisouvik's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 18, 2026

Copy link
Copy Markdown

@SUMAN967-GHOSH Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@thisisouvik
thisisouvik merged commit b24407c into thisisouvik:main Oct 18, 2026
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECH STACK / QUALITY] Remove @ts-nocheck directives and eliminate cascading render warnings in AccountClient

2 participants