-
Notifications
You must be signed in to change notification settings - Fork 369
Trace - make clear that trace context is unused with Zephyr #11102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ | |
| LOG_MODULE_REGISTER(basefw, CONFIG_SOF_LOG_LEVEL); | ||
|
|
||
| SOF_DEFINE_REG_UUID(basefw); | ||
| /* unused with Zephyr, generates no output */ | ||
| DECLARE_TR_CTX(basefw_comp_tr, SOF_UUID(basefw_uuid), LOG_LEVEL_INFO); | ||
|
|
||
| static struct ipc4_system_time_info global_system_time_info; | ||
|
|
@@ -850,7 +851,9 @@ __cold static int basefw_set_large_config(struct comp_dev *dev, uint32_t param_i | |
|
|
||
| static const struct comp_driver comp_basefw = { | ||
| .uid = SOF_RT_UUID(basefw_uuid), | ||
| #ifndef __ZEPHYR__ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could this be reversed? I mean these are only needed in LIBRARY builds now (or are they even needed there)? Or maybe that's not accurate enough, but maybe "#ifdef CONFIG_TRACE" (i.e. a build really using sof-logger with dictionaries). And for Zephyr, this doesn't cover the case where you build with Zephyr but disable CONFIG_ZEPHYR_LOG. I think these cases should be prevented somehow. |
||
| .tctx = &basefw_comp_tr, | ||
| #endif | ||
| .ops = { | ||
| .get_large_config = basefw_get_large_config, | ||
| .set_large_config = basefw_set_large_config, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,7 @@ static const uint32_t max_chain_number = DT_NUM_HDA_HOST_OUT + DT_NUM_HDA_HOST_I | |
| LOG_MODULE_REGISTER(chain_dma, CONFIG_SOF_LOG_LEVEL); | ||
|
|
||
| SOF_DEFINE_REG_UUID(chain_dma); | ||
| /* unused with Zephyr, generates no output */ | ||
| DECLARE_TR_CTX(chain_dma_tr, SOF_UUID(chain_dma_uuid), LOG_LEVEL_INFO); | ||
|
|
||
| /* chain dma component private data */ | ||
|
|
@@ -787,7 +788,9 @@ __cold static void chain_task_free(struct comp_dev *dev) | |
|
|
||
| static const struct comp_driver comp_chain_dma = { | ||
| .uid = SOF_RT_UUID(chain_dma_uuid), | ||
| #ifndef __ZEPHYR__ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Zephyr is only RTOS now. We can remove support for legacy after v2.15 |
||
| .tctx = &chain_dma_tr, | ||
| #endif | ||
| .ops = { | ||
| .create = chain_task_create, | ||
| .trigger = chain_task_trigger, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"srop trace context"?