fix(renderer): propagate style to generated operators - #43
Merged
thatmagicalcat merged 1 commit intoJul 19, 2026
Merged
Conversation
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Summary
-,', and binary operator cells use the same color and attributes as their surrounding expressionWhy
Rendered child nodes already carried
RenderCtx::current_style, but punctuation generated directly by these composite layout nodes still used the default empty style. That left operators uncolored inside styled expressions even though adjacent identifiers were styled correctly.Tests
cargo fmt --checkcargo testcargo clippy -- -D warningscargo test --all-featuresis currently blocked onmainby the pre-existing unresolvedcrate::backends::memoryimport insrc/ratatui.rs; the repository's configured CI commands above all pass.