Repository navigation
test(history): respect workflow lock lifecycle in task completion suite - #12971
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Hold workflow locks when accessing workflow context and mutable state in WorkflowTaskCompletedHandlerSuite. Scope lock acquisition inside createSentUpdate and direct-access test cases, and drop redundant LoadMutableState calls after releasing back to cache. Fixes temporalio#12784
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
createSentUpdatewithwfContext.Lockand deferredwfContext.Unlock.LoadMutableState,AddTimerStartedEvent,AddTimerFiredEvent,Clear,TimeoutWorkflow,UpdateWorkflowExecutionAsActive,SubmitClosedWorkflowSnapshot,GetMergedTaskCompletionPages) inTestUpdateWorkflow,TestForceCreateNewWorkflowTaskOnPausedWorkflow, andTestWorkflowTaskCompletionPaginationunderwfContext.Lock.LoadMutableStateinvocations followingcreateStartedWorkflowrelease in deployment-metrics and pagination test cases.Fixes #12784
Why?
createStartedWorkflowreleases the workflow lock back to the cache before returning the workflow context. Subsequent test calls tocreateSentUpdateand direct mutable state access helpers interacted with mutable state and update registry outside the workflow lock, violating lock assertions in the history unit suite.How did you test it?
Executed test suite in container sandbox:
go test -tags test_dep ./service/history/api/respondworkflowtaskcompleted -run WorkflowTaskCompletedHandlerSuite -count=1go vet ./service/history/api/respondworkflowtaskcompletedPotential risks
None. Test-only change in
service/history/api/respondworkflowtaskcompleted/api_test.go.