Repository navigation
fix activity and workflow task time-skipping clock boundaries - #12960
Open
feiyang3cat wants to merge 2 commits into
Open
feiyang3cat wants to merge 2 commits into
feiyang3cat wants to merge 2 commits into
Conversation
feiyang3cat
marked this pull request as ready for review
November 6, 2026 01:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Use the workflow’s virtual clock when rescheduling activities through reset/unpause operations and determining whether pending activities are waiting for retry backoff.
Convert workflow task scheduled/started timestamps to real time before comparing them with physical timeout task timestamps for best-effort deletion.
Why?
After time skipping, the workflow’s virtual clock differs from the shard’s real clock. Mixing these clocks can:
These issues also apply after time skipping is disabled because the accumulated offset remains.
How did you test it?