Repository navigation
WorkerSessionOptions + ActivitySessionOptions -- Defining Sessions #885
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package temporal.api.session.v1; | ||
|
|
||
| option go_package = "go.temporal.io/api/session/v1;session"; | ||
| option java_package = "io.temporal.api.session.v1"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "MessageProto"; | ||
| option ruby_package = "Temporalio::Api::Session::V1"; | ||
| option csharp_namespace = "Temporalio.Api.Session.V1"; | ||
|
|
||
| import "google/protobuf/empty.proto"; | ||
|
|
||
| // EXPERIMENTAL. Subject to redesign or removal. | ||
| // Sent on workflow and activity polls. Presence means this worker can serve | ||
| // sessions. Currently, the only supported Session type is Workflow Session | ||
| // (aka Workflow-as-Session). A Workflow Session can receive both workflow | ||
| // tasks and activity tasks of an execution. | ||
| message WorkerSessionOptions { | ||
| // Admission control, if unset the worker accepts an arbitrary number of | ||
| // sessions (bounded by session slots in the future) | ||
| oneof admission { | ||
| // If specified, the worker only polls for work belonging to its session. | ||
| SingleSessionOptions single_session = 1; | ||
| } | ||
| } | ||
|
|
||
| // EXPERIMENTAL. Subject to redesign or removal. | ||
| // Serve exactly one session for the worker's lifetime, including across | ||
| // process restarts with the same stable_identity. The server binds the worker | ||
| // to the first session that needs a worker, and dispatches no other work here, | ||
| // even after that session completes. | ||
| message SingleSessionOptions { | ||
| // Identity the binding is stored under. Required; must be non-empty. | ||
| // Reuse it across restarts of the same session, not across concurrently | ||
| // running workers. If multiple workers poll with the same stable_identity | ||
| // concurrently, the server treats them as pollers of a single worker and | ||
| // process affinity is lost. | ||
| // | ||
| // Note: this effectively acts as a configurable sticky queue. | ||
| // Note: we are currently unsure how this will evolve. May be deprecated as | ||
| // the session model develops. | ||
| string stable_identity = 1; | ||
| } | ||
|
|
||
| // EXPERIMENTAL. Subject to redesign or removal. | ||
| // Resolved activity placement. Unset = normal task-queue routing. | ||
| message ActivitySessionOptions { | ||
|
Member
Author
There was a problem hiding this comment. i envision these options to be sent on the command attributes when we are going to schedule an activity task -- if that is the case, i wonder if we should have something defined or thought of for the stable identity piece (single session isolation) given that we seem to have thought this in the poll request structures if not, then i wonder if we do even need the single session options defined in the general WorkerSessionOptions |
||
| oneof placement { | ||
| // Run in the workflow's current session (on its sticky queue). | ||
| // Currently requires the activity's task queue to be the workflow's, | ||
| // and the workflow's worker to serve sessions. | ||
| google.protobuf.Empty workflow_session = 1; | ||
|
|
||
| // Future: references to other types of sessions. | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thomas: says that maybe we should think about what this is called if we wanna ActivitySessionOptions