Repository navigation
Enhance comments in task_queue.proto for clarity - #668
Merged
Merged
Conversation
Added comments to clarify the purpose of TaskQueueKind.
Updated comments for clarity in task_queue.proto
cretz
approved these changes
Nov 21, 2025
dnr
approved these changes
Nov 21, 2025
stephanos
pushed a commit
that referenced
this pull request
Mar 10, 2026
Added comments to clarify the purpose of TaskQueueKind. _**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Added comments to `TaskQueueKind` clarifying that the field is for wether a task queue is sticky and therefore only applies to workflow tasks; thus will be unspecified if it is for any non-workflow task <!-- Tell your future self why have you made these changes --> **Why?** Requested by Temporal Cloud Customer for Clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comments to clarify the purpose of TaskQueueKind.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Added comments to
TaskQueueKindclarifying that the field is for wether a task queue is sticky and therefore only applies to workflow tasks; thus will be unspecified if it is for any non-workflow taskWhy?
Requested by Temporal Cloud Customer for Clarity