Skip to content

Add Deployment Options for Eager start - #645

Merged
ShahabT merged 2 commits into
masterfrom
shahab/eager-versioning
Oct 8, 2025
Merged

ShahabT merged 2 commits into
masterfrom
shahab/eager-versioning

Conversation

@ShahabT

@ShahabT ShahabT commented Oct 8, 2025 •

Copy link
Copy Markdown
Contributor

What changed?
Added eager_worker_deployment_options to StartWorkflowExecutionRequest.

Why?
So server knows the versioning info of the worker who would process the eager task. Server can ignore the eager flag if the worker doesn't have the Current version.

Breaking changes
None

Server PR

@ShahabT
ShahabT requested review from a team as code owners October 8, 2025 22:33

@Sushisource Sushisource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@ShahabT
ShahabT merged commit e1c9754 into master Oct 8, 2025
4 checks passed
@ShahabT
ShahabT deleted the shahab/eager-versioning branch October 8, 2025 23:59
stephanos pushed a commit that referenced this pull request Mar 10, 2026
**What changed?**
Added `eager_worker_deployment_options` to
`StartWorkflowExecutionRequest`.

<!-- Tell your future self why have you made these changes -->
**Why?**
So server knows the versioning info of the worker who would process the
eager task. Server can ignore the eager flag if the worker doesn't have
the Current version.

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**
None

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
**Server PR**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants