Repository navigation
add degraded workflow visibility into NamespaceInfo.Capabilities - #643
Merged
Merged
Conversation
bergundy
approved these changes
Sep 30, 2025
cretz
approved these changes
Sep 30, 2025
| // True if the namespace supports worker heartbeats | ||
| bool worker_heartbeats = 4; | ||
| // True if the namespace supports degraded workflow visibility | ||
| bool degraded_workflow_visibility = 5; |
Contributor
There was a problem hiding this comment.
Would suggest a rename, e.g. reported_problems_search_attribute or something heh. At first glance I read this as there was a form of workflow visibility that was degraded from the normal form if this was true. This is not blocking, though I am not sure the word "degraded" is the best product name.
added 2 commits
September 30, 2025 16:12
stephanos
pushed a commit
that referenced
this pull request
Mar 10, 2026
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Adding `degraded_workflow_visibility` to `NamespaceInfo.Capabilities`. <!-- Tell your future self why have you made these changes --> This will allow us to programmatically turn on the saved query for degraded workflow visibility. **Breaking changes** No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Adding
degraded_workflow_visibilitytoNamespaceInfo.Capabilities.This will allow us to programmatically turn on the saved query for degraded workflow visibility.
Breaking changes
No