Fix OSR mouse input handling - #1
Open
natanhnrqe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues with mouse input handling in OSR mode:
Mouse button identity was inferred from the current button-down state. On JavaFX mouse release events, this state is already false, causing secondary button releases to be sent to CEF as left button releases. The button is now determined using
MouseEvent.getButton().ScrollEventwas passed to a helper that expects mouse-specific methods such asisMiddleButtonDown(), causing aNoSuchMethodError. Common keyboard modifiers are now handled separately from mouse button state.Tested with the official CEFFX demo on Windows. Right-click, middle-click, left-click, scrolling, and text selection work correctly, with no mouse wheel JNI exceptions.