Repository navigation
Fix CodeQL workflow alerts: pin third-party actions, scope CI token #94
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,37 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
| push: | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| ci: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out the repository | ||
| uses: actions/checkout@v7 | ||
|
|
||
| - name: Set up pnpm and Node.js, install dependencies | ||
| uses: pnpm/setup@fbda4c85fc2e1e08721cd8763afea8f48d60f024 # v3.0.0 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: true | ||
| require-lockfile: true | ||
|
There was a problem hiding this comment. Lockfile input is not validLow Severity
Additional Locations (2)  Reviewed by Cursor Bugbot for commit 7998b37. Configure here. |
||
|
|
||
| - name: Lint | ||
| run: pnpm lint | ||
|
|
||
| - name: Check formatting | ||
| run: pnpm format:check | ||
|
|
||
| - name: Build | ||
| run: pnpm build | ||
|
|
||
| # The build regenerates the SDK from the committed schema, so any diff means a generated file | ||
| # was edited by hand or not regenerated after a schema or generator change. | ||
| - name: Check generated files are up to date | ||
|
|
@@ -28,29 +41,40 @@ jobs: | |
| echo "::error::Generated files are out of date. Run pnpm build and commit the result." | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Typecheck | ||
| run: pnpm typecheck | ||
|
|
||
| - name: Test | ||
| run: pnpm test | ||
|
|
||
| package: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out the repository | ||
| uses: actions/checkout@v7 | ||
|
|
||
| - name: Set up pnpm and Node.js, install dependencies | ||
| uses: pnpm/setup@fbda4c85fc2e1e08721cd8763afea8f48d60f024 # v3.0.0 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: true | ||
| require-lockfile: true | ||
|
|
||
| - name: Build | ||
| run: pnpm build | ||
|
|
||
| # Raw size, not compressed: an unminified build can be twice the size and gzip the same. | ||
| - name: Check the built JS stays within its size limits | ||
| run: pnpm exec size-limit | ||
|
|
||
| - name: Check exports and types resolve in every module mode | ||
| run: | | ||
| for pkg in graphql ui-components webhooks; do | ||
| pnpm exec attw --pack "packages/$pkg" | ||
| pnpm exec publint "packages/$pkg" | ||
| done | ||
|
|
||
| - name: Install the packed packages and load them | ||
| run: | | ||
| mkdir -p "$RUNNER_TEMP/packs" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm/setup ignores Node version file
Medium Severity
pnpm/setupdoes not acceptnode-version-file, so the new.nvmrcis ignored and CI, release, and schema jobs no longer pin Node 24. The action only honorsruntimeordevEngines.runtime, neither of which is set, so these workflows stay on the runner default instead of the>=24engines pin.Additional Locations (2)
.github/workflows/release.yml#L21-L27.github/workflows/update-schema.yml#L33-L39Reviewed by Cursor Bugbot for commit 501d0dd. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's wrong: https://github.com/pnpm/setup#inputs