Repository navigation
Conversation
mpsq
enabled auto-merge (squash)
October 15, 2026 23:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm 12 writes its own pinned version as a first YAML document in
pnpm-lock.yaml. GitHub's dependency graph reads only that document, so the SBOM dropped to direct dependencies and Dependabot auto-closed alerts as "fixed" while the vulnerable versions were still locked (dependabot/dependabot-core#15904).pmOnFail: ignoreinpnpm-workspace.yamlso pnpm stops writing that documentpnpm-lock.yaml; the dependency document is unchanged byte for bytepnpm/setup, which readspackageManager, so CI is unaffected. Locally, pnpm no longer auto-switches to the pinned versionNote
Low Risk
Workspace-only pnpm configuration; no application runtime changes, with CI package-manager install path unchanged.
Overview
Restores Dependabot visibility by setting
pmOnFail: ignoreinpnpm-workspace.yaml, so pnpm 12 stops prepending a separatepackageManagerdocument topnpm-lock.yaml. GitHub’s dependency graph only read that first document, which hid the real lockfile and broke SBOM/alert accuracy (dependabot-core#15904).Inline comments document why the option exists. CI still gets the pinned pnpm via
pnpm/setupandpackageManager; locally, pnpm no longer auto-switches to the pinned version when the pin check fails.Reviewed by Cursor Bugbot for commit ec79d65. Bugbot is set up for automated code reviews on this repo. Configure here.