Failing to build on Fedora 43 Kernel 6.18.10-200

[gbirchley]

Build fails after upgrading to Fedora 43
Afraid I have not got the skills to work out what is causing the problem :(

~/Downloads/media_build$ make allyesconfig
make -C /home/mythtv/Downloads/media_build/v4l allyesconfig
make[1]: Entering directory '/home/mythtv/Downloads/media_build/v4l'
No version yet, using 6.18.10-200.fc43.x86_64
make[2]: Entering directory '/home/mythtv/Downloads/media_build/linux'
Syncing with dir ../../media
Applying patches for kernel 6.18.10-200.fc43.x86_64
patch -s -f -N -p1 -i ../backports/api_version.patch
patch -s -f -N -p1 -i ../backports/pr_fmt.patch
patch -s -f -N -p1 -i ../backports/debug.patch
patch -s -f -N -p1 -i ../backports/drx39xxj.patch
patch -s -f -N -p1 -i ../backports/ccs.patch
patch -s -f -N -p1 -i ../backports/rc-cec.patch
Patched drivers/media/dvb-core/dvbdev.c
Patched drivers/media/v4l2-core/v4l2-dev.c
Patched drivers/media/rc/rc-main.c
Syncing with dir ../../media
make[2]: Leaving directory '/home/mythtv/Downloads/media_build/linux'
./scripts/make_kconfig.pl /lib/modules/6.18.10-200.fc43.x86_64/build /lib/modules/6.18.10-200.fc43.x86_64/source 1
Preparing to compile for kernel version 6.18.10

***WARNING:*** You do not have the full kernel sources installed.
This does not prevent you from building the v4l-dvb tree if you have the
kernel headers, but the full kernel source may be required in order to use
make menuconfig / xconfig / qconfig.

If you are experiencing problems building the v4l-dvb tree, please try
building against a vanilla kernel before reporting a bug.

Vanilla kernels are available at http://kernel.org.
On most distros, this will compile a newly downloaded kernel:

cp /boot/config-`uname -r` <your kernel dir>/.config
cd <your kernel dir>
make all modules_install install

Please see your distro's web site for instructions to build a new kernel.

WARNING: This is the V4L/DVB backport tree, with experimental drivers
         backported to run on legacy kernels from the development tree at:
                http://git.linuxtv.org/media-tree.git.
         It is generally safe to use it for testing a new driver or
         feature, but its usage on production environments is risky.
         Don't use it in production. You've been warned.
VIDEO_ROCKCHIP_ISP1: Requires at least kernel 9.255.255
VIDEO_XILINX: Requires at least kernel 9.255.255
VIDEO_OV772X: Requires at least kernel 9.255.255
VIDEO_OV9650: Requires at least kernel 9.255.255
VIDEO_TC358746: Requires at least kernel 9.255.255
INTEL_ATOMISP: Requires at least kernel 9.255.255
VIDEO_IPU3_IMGU: Requires at least kernel 9.255.255
Created default (all yes) .config file
./scripts/fix_kconfig.pl
make[1]: Leaving directory '/home/mythtv/Downloads/media_build/v4l'
~/Downloads/media_build$ sed -i -r 's/(^CONFIG.*_RC.*=)./\1n/g' v4l/.config
~/Downloads/media_build$ sed -i -r 's/(^CONFIG.*_IR.*=)./\1n/g' v4l/.config
~/Downloads/media_build$ make
make -C /home/mythtv/Downloads/media_build/v4l 
make[1]: Entering directory '/home/mythtv/Downloads/media_build/v4l'
./scripts/make_myconfig.pl
scripts/make_makefile.pl
[ ! -f "./config-mycompat.h" ] && echo "/* empty config-mycompat.h */" > "./config-mycompat.h" || true
perl scripts/make_config_compat.pl /lib/modules/6.18.10-200.fc43.x86_64/source ./.myconfig ./config-compat.h
creating symbolic links...
make -C firmware prep
make[2]: Entering directory '/home/mythtv/Downloads/media_build/v4l/firmware'
make[2]: Nothing to be done for 'prep'.
make[2]: Leaving directory '/home/mythtv/Downloads/media_build/v4l/firmware'
make -C firmware
make[2]: Entering directory '/home/mythtv/Downloads/media_build/v4l/firmware'
make[2]: Nothing to be done for 'default'.
make[2]: Leaving directory '/home/mythtv/Downloads/media_build/v4l/firmware'
Kernel build directory is /lib/modules/6.18.10-200.fc43.x86_64/build
make -C ../linux apply_patches
make[2]: Entering directory '/home/mythtv/Downloads/media_build/linux'
Syncing with dir ../../media
Patches for 6.18.10-200.fc43.x86_64 already applied.
make[2]: Leaving directory '/home/mythtv/Downloads/media_build/linux'
make -C /lib/modules/6.18.10-200.fc43.x86_64/build M=/home/mythtv/Downloads/media_build/v4l  modules
make[2]: Entering directory '/usr/src/kernels/6.18.10-200.fc43.x86_64'
make[3]: Entering directory '/home/mythtv/Downloads/media_build/v4l'
  CC [M]  max2175.o
  CC [M]  ad5820.o
  CC [M]  adp1653.o
  CC [M]  adv7170.o
  CC [M]  adv7175.o
  CC [M]  adv7180.o
  CC [M]  adv7183.o
  CC [M]  adv7343.o
  CC [M]  adv7393.o
  CC [M]  adv7511-v4l2.o
  CC [M]  adv7604.o
  CC [M]  adv7842.o
  CC [M]  ak7375.o
  CC [M]  ak881x.o
  CC [M]  aptina-pll.o
  CC [M]  ar0521.o
  CC [M]  bt819.o
  CC [M]  bt856.o
  CC [M]  bt866.o
  CC [M]  ccs-core.o
  CC [M]  ccs-reg-access.o
  CC [M]  ccs-quirk.o
  CC [M]  ccs-limits.o
  CC [M]  ccs-data.o
  LD [M]  ccs.o
  CC [M]  ccs-pll.o
  CC [M]  cs3308.o
  CC [M]  cs5345.o
  CC [M]  cs53l32a.o
  CC [M]  cx25840-core.o
  CC [M]  cx25840-audio.o
In file included from cx25840-audio.c:6:
/home/mythtv/Downloads/media_build/v4l/../linux/include/uapi/linux/videodev2.h:2539:41: error: field 'timestamp' has incomplete type
 2539 |         struct __kernel_timespec        timestamp;
      |                                         ^~~~~~~~~
make[5]: *** [/usr/src/kernels/6.18.10-200.fc43.x86_64/scripts/Makefile.build:287: cx25840-audio.o] Error 1
make[4]: *** [/usr/src/kernels/6.18.10-200.fc43.x86_64/Makefile:2047: .] Error 2
make[3]: *** [/usr/src/kernels/6.18.10-200.fc43.x86_64/Makefile:248: __sub-make] Error 2
make[3]: Leaving directory '/home/mythtv/Downloads/media_build/v4l'
make[2]: *** [Makefile:248: __sub-make] Error 2
make[2]: Leaving directory '/usr/src/kernels/6.18.10-200.fc43.x86_64'
make[1]: *** [Makefile:53: default] Error 2
make[1]: Leaving directory '/home/mythtv/Downloads/media_build/v4l'
make: *** [Makefile:26: all] Error 2

[massweet]

I have just tried making against a 6.17 kernel on ubuntu, and using make that is the first error I see, using make -k I see several errors, that lead me to believe that something has gone wrong with the order of finding include files. For instance:

1. include/uapi/linux/videodev2.h does not know about struct __kernel_timespec which is in include/uapi/linux/time_types.h
2. The code is not finding the macro from_timer, or the function del_timer_sync (and others) which are declared in include/linux/timer.h
3. We do not seem to be picking up the kernel config, leading to the compiler complaining about redeclarations of _attach() functions.
4. We do not seem to be picking up the local include/linux/sysfs.h, leading to a compilation error in drivers/media/i2c/imx208.c where an extra "const" becomes necessary.
5. We do not seem to be picking up LINUX_VERSION_CODE or KERNEL_VERSION(), leading to several errors.

tc358743.c: In function 'tc358743_irq_poll_timer': tc358743.c:1477:40: error: implicit declaration of function 'from_timer'; did you mean 'mod_timer'? [-Werror=implicit-function-declaration] 1477 | struct tc358743_state *state = from_timer(state, t, timer); | ^~~~~~~~~~ | mod_timer tc358743.c:1477:61: error: 'timer' undeclared (first use in this function); did you mean 'ktimerd'? 1477 | struct tc358743_state *state = from_timer(state, t, timer); | ^~~~~ | ktimerd tc358743.c:1477:61: note: each undeclared identifier is reported only once for each function it appears in tc358743.c: In function 'tc358743_remove': tc358743.c:2177:17: error: implicit declaration of function 'del_timer_sync' [-Werror=implicit-function-declaration] 2177 | del_timer_sync(&state->timer); | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors
tda18273.c:2145:22: error: redefinition of 'tda18273_attach' 2145 | struct dvb_frontend *tda18273_attach(struct dvb_frontend *fe, | ^~~~~~~~~~~~~~~ In file included from tda18273.c:26: tda18273.h:33:36: note: previous definition of 'tda18273_attach' with type 'struct dvb_frontend *(struct dvb_frontend *, struct i2c_adapter *, const u8)' {aka 'struct dvb_frontend *(struct dvb_frontend *, struct i2c_adapter *, const unsigned char)'} 33 | static inline struct dvb_frontend *tda18273_attach(struct dvb_frontend *fe,
In file included from tas2101.c:31: tas2101_priv.h:25:5: warning: "LINUX_VERSION_CODE" is not defined, evaluates to 0 [-Wundef] 25 | #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0) | ^~~~~~~~~~~~~~~~~~

imx208.c:876:26: error: initialization of 'ssize_t (*)(struct file *, struct kobject *, const struct bin_attribute *, char *, loff_t, size_t)' {aka 'long int (*)(struct file *, struct kobject *, const struct bin_attribute *, char *, long long int, long unsigned int)'} from incompatible pointer type 'ssize_t (*)(struct file *, struct kobject *, struct bin_attribute *, char *, loff_t, size_t)' {aka 'long int (*)(struct file *, struct kobject *, struct bin_attribute *, char *, long long int, long unsigned int)'} [-Werror=incompatible-pointer-types] 876 | static const BIN_ATTR_RO(otp, IMX208_OTP_SIZE); | ^~~ /usr/src/linux-headers-6.17.0-14-generic/include/linux/sysfs.h:338:17: note: in definition of macro '__BIN_ATTR' 338 | .read = _read, \ | ^~~~~ /usr/src/linux-headers-6.17.0-14-generic/include/linux/sysfs.h:359:41: note: in expansion of macro '__BIN_ATTR_RO' 359 | struct bin_attribute bin_attr_##_name = __BIN_ATTR_RO(_name, _size) | ^~~~~~~~~~~~~ imx208.c:876:14: note: in expansion of macro 'BIN_ATTR_RO' 876 | static const BIN_ATTR_RO(otp, IMX208_OTP_SIZE); | ^~~~~~~~~~~ imx208.c:876:26: note: (near initialization for 'bin_attr_otp.read') 876 | static const BIN_ATTR_RO(otp, IMX208_OTP_SIZE); | ^~~ /usr/src/linux-headers-6.17.0-14-generic/include/linux/sysfs.h:338:17: note: in definition of macro '__BIN_ATTR' 338 | .read = _read, \ | ^~~~~ /usr/src/linux-headers-6.17.0-14-generic/include/linux/sysfs.h:359:41: note: in expansion of macro '__BIN_ATTR_RO' 359 | struct bin_attribute bin_attr_##_name = __BIN_ATTR_RO(_name, _size) | ^~~~~~~~~~~~~ imx208.c:876:14: note: in expansion of macro 'BIN_ATTR_RO' 876 | static const BIN_ATTR_RO(otp, IMX208_OTP_SIZE); | ^~~~~~~~~~~

[AndyHarvey99]

FYI, There is a new method for installing TBS drivers referred to here [https://github.com//issues/411]

[gbirchley]

Thank-you for this advice- I can confirm this works:

su -c "curl -sSf https://www.tbsdtv.com/download/document/linux/drv-tbs.sh | sh"

Although I'm slightly uneasy about the invisibility of the code, it is certainly a much easier method for someone like me without coding skills.

[massweet]

Did that, the kernel only finds one (of 4) adapters, so not useful.

There are obvious code flaws. How do I report bugs against that?

[Davin622]

Please running this command with root permission
curl -sSf https://www.tbsdtv.com/download/document/linux/drv-tbs.sh | sh

BTW. what is the product you used?

[massweet]

I have two cards, a TBS6902 and a TBS6281:

`$ for i in 05 07 ; do sudo lspci -v -s ${i}: ; done
05:00.0 Multimedia controller: TBS Technologies DVB Tuner PCIe Card
Subsystem: Device 6902:0002
Flags: bus master, fast devsel, latency 0, IRQ 81, IOMMU group 14
Memory at f7300000 (32-bit, non-prefetchable) [size=256K]
Capabilities: [50] Power Management version 3
Capabilities: [70] MSI: Enable+ Count=1/1 Maskable- 64bit+
Capabilities: [90] Express Endpoint, MSI 00
Capabilities: [100] Device Serial Number 00-00-00-00-00-00-00-00
Kernel driver in use: TBSECP3 driver
Kernel modules: tbsecp3

07:00.0 Multimedia controller: TBS Technologies DVB Tuner PCIe Card
Subsystem: Device 6281:0002
Flags: bus master, fast devsel, latency 0, IRQ 84, IOMMU group 14
Memory at f7200000 (32-bit, non-prefetchable) [size=256K]
Capabilities: [50] Power Management version 3
Capabilities: [70] MSI: Enable+ Count=1/1 Maskable- 64bit+
Capabilities: [90] Express Endpoint, MSI 00
Capabilities: [100] Device Serial Number 00-00-00-00-00-00-00-00
Kernel driver in use: TBSECP3 driver
Kernel modules: tbsecp3`

[massweet]

Sorry, my initial request was rather terse. Here's a better breakdown of why:

1. I do not like running scripts as root - you should only use sudo for those scripts which actually need to be root.
2. The kernel-building packages allow you to build/install modules for another kernel version, which your install.sh does not support.
3. Please do not delete the source tree after using it.

[massweet]

...and I can confirm that the v1012 version does find four adapters with a 6.17 kernel. About to do some testing it works.

[Shininess8816]

New method does not work for me. Modules appear to be missing for my card? They do not appear in /dev/dvb after a reboot. I would usually avoid a reboot with modprobe saa716x_tbs-dvb int_type=1

modprobe saa716x_tbs-dvb int_type=1 modprobe: FATAL: Module saa716x_tbs-dvb not found in directory /lib/modules/6.17.13-1-pve

I can however see the lines

CC [M] pci/saa716x/saa716x_core.mod.o CC [M] pci/saa716x/saa716x_tbs-dvb.mod.o

So I don't know. Will pin a 6.14 kernel...

[AndyHarvey99]

Try using v1002, that's the last one that worked for my card which uses a saa716x module.

[Shininess8816]

I'm pretty sure I had to the same issue with 1002....Yep...Looks like it

[Novgorod]

Try using v1002, that's the last one that worked for my card which uses a saa716x module.

Holy heck, I was about to rip out the few remaining hair I have left! Indeed, the latest (v1012) does not work with saa716x (no kernel module), but v1002 works just fine. Tested on kernel 6.17.13-1-pve.

[thecosmicslug]

This whole mess is incredibly confusing... I'm chipping in here to add that my card (TBS6285) is not recognised by either v1002 or v1012 despite what people say here. so it looks like i'm stuck on an old kernel version again.

[Shininess8816]

Try some combination of what I did below - Now working
It was either copying the firmware or the modules.

This could in theory be working with the newer script - But that automatically deletes the tbsdvb folder - If I remember correctly. I've been using the modprobe methods at the bottom (though I have to remove core this time to make it work....) vs rebooting for the last few years

cd ~/
rm -r tbsdvb
rm tbsdvb_v1002.tar.bz2
curl -sSf -O https://www.tbsiptv.com/download/common/tbsdvb_v1002.tar.bz2 &&
tar -jxvf tbsdvb_v1002.tar.bz2 &&
cd tbsdvb/ &&
./install.sh &&
mkdir -p /lib/modules/$(uname -r)/updates &&
cp -r ./ /lib/modules/$(uname -r)/updates/ &&
tar -xvjf tbs-tuner-firmwares*.tar.bz2 -C /lib/firmware/ &&
#modprobe -r snd_usb_audio &&
#modprobe -r mc &&
modprobe -r saa716x_tbs-dvb &&
modprobe -r dvb_core &&
modprobe saa716x_tbs-dvb int_type=1

[thecosmicslug]

thank you for the advice about dvb_core, but unfortunately it still doesn't work. modprobe claims saa716x_tbs-dvb doesnt exist.