-
Notifications
You must be signed in to change notification settings - Fork 0
feat(control-plane)!: /ws/events says when it is live, over an ordered in-process event bus #1863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
cebbbb6
80a5cb9
9a4bfb8
623f2b6
ef9e401
d721c0d
c15eb45
423605f
d14f9be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,10 +70,14 @@ driver stamp. Rust reaches it through `MediaClock`; Python through `monotonic_no | |
| siblings). | ||
| 3. Log file naming — `started_at_millis` (`core/logging/init.rs:185`, | ||
| `core/logging/paths.rs:22`) and the CLI's rendering of both (`commands/logs.rs:222`). | ||
| 4. Control-plane pubsub event `timestamp_ns` (`core/pubsub/bus.rs:263-268`). | ||
| 4. ~~Control-plane pubsub event `timestamp_ns` (`core/pubsub/bus.rs:263-268`).~~ — | ||
| Superseded 2026-08-13 by #1783: the control-plane event bus became an in-process | ||
| registry, so its events no longer cross a wire and carry no timestamp to stamp. The | ||
| surface ceased to exist rather than being retracted; `check-clock-usage` now permits | ||
| three. | ||
|
|
||
| Their job is correlating StreamLib with the outside world and with other hosts' logs — a | ||
| job monotonic time cannot do. Adding a fifth surface is a plan change, not a judgement | ||
| job monotonic time cannot do. Adding a further surface is a plan change, not a judgement | ||
|
Comment on lines
+73
to
+80
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Update the remaining four-surface references. This change states that Suggested wording changes-### Wall clock — permitted on exactly these four surfaces, and nowhere else
+### Wall clock — permitted on exactly these three surfaces, and nowhere else
- > The permitted list holds exactly the four surfaces...
+ > The permitted list holds exactly the three surfaces...🧰 Tools🪛 LanguageTool[style] ~80-~80: This phrase might be redundant. Consider either removing or replacing the adjective ‘further’. (ADD_AN_ADDITIONAL) 🤖 Prompt for AI Agents |
||
| call. | ||
|
|
||
| ### The rule that keeps the two from mixing | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: tatolab/streamlib
Length of output: 155
🏁 Script executed:
Repository: tatolab/streamlib
Length of output: 3450
Replace the broken learning link. The file
docs/learnings/pubsub-lazy-init-silent-noop.mddoes not exist. Use plain text or a valid archive or issue reference.🤖 Prompt for AI Agents