chore!: retire the manifest, schema and codegen layer from the consumer trees - #1854
Merged
Merged
Conversation
Contributor
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (117)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…er trees Every artifact here belongs to a concept the engine already deleted. Nothing reads any of it, and none of it could build. - 28 `streamlib.yaml` manifests. The manifest is a deleted concept — §Product's zero-ceremony bar is "no manifest authoring" — and the JSON Schema each one opens by referencing, `schemas/streamlib.schema.json`, was deleted by #1715. The only code that names `streamlib.yaml` today asserts a scaffolded app has none (`hello_streamlib_example_e2e.rs:216`, `app_sugar_test.rs:210`). - 50 `packages/*/schemas/*.yaml`. There is no schema layer: no JTD, no registry, no codegen, no generated type classes (schema-free-ports, #1813/#1815). - 13 `streamlib-codegen.lock`. The lockfile of the deleted codegen; nothing in the tree references one. - 18 `build.rs` that call `streamlib_jtd_codegen::build_rs::run_for_rust_crate()`, and the 21 `[build-dependencies]` entries naming that crate. The crate was deleted with the schema layer, so each of those packages fails at build-script compilation before reaching its own source. The consumer trees stay broken — they are written against the deleted identity grammar and that is the wanted signal — but they now fail for one honest reason instead of four, which is what makes the eventual port readable. `packages/core` and `packages/escalate` held nothing but a manifest and schemas, so both are now empty and gone from the index. The 18 `_generated_rust_crate_root_/lib.rs` stay. They are codegen output of the same dead layer, but each is named by its own `[lib] path` and none of those packages carries a `src/`, so removing one leaves a crate with no root at all. Giving each a real crate root is the port, not this cleanup. `packages/test-fixtures` keeps its `build.rs` and `shaders/`: that script compiles GLSL to SPIR-V for the kernel fixtures and never read a schema. It is the one workspace member here and still builds. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tato123
force-pushed
the
chore/retire-the-manifest-and-schema-layer
branch
from
August 12, 2026 17:37
66b075b to
69f3619
Compare
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
109 files deleted, 21
Cargo.tomlcleaned — 4,803 lines. Every artifact belongs to a concept the engine already removed. Nothing reads any of it, and none of it could build.streamlib.yamlmanifestsschemas/streamlib.schema.json— the file every one of them opens by referencing — was deleted by #1715.packages/*/schemas/*.yamlstreamlib-codegen.lockbuild.rscallingstreamlib_jtd_codegen[build-dependencies] streamlib-jtd-codegenThe consumer trees stay broken — they are written against the deleted identity grammar and that is the wanted signal — but they now fail for one honest reason instead of four, which is what makes the eventual port readable.
packages/coreandpackages/escalateheld nothing but a manifest and schemas, so both are now empty and gone from the index.What deliberately stays
The 18
_generated_rust_crate_root_/lib.rsfiles are codegen output of the same dead layer, and I left them. Each is named by its own[lib] path = "_generated_rust_crate_root_/lib.rs", and none of those packages carries asrc/— so deleting one leaves a crate with no root at all. Giving each a real crate root is the port, not this cleanup.Verification
Every claim checked before deleting, not after:
streamlib.yaml. The only three code references are negative assertions that a scaffolded app has none —hello_streamlib_example_e2e.rs:216(forbidden_files = ["build.rs", "streamlib.yaml"]),app_sugar_test.rs:210, and a comment inprocessor_schema_parser.rs.schemas/streamlib.schema.jsonis already gone — confirmed absent from the index.streamlib-codegen.lock— grep across*.rs,*.toml,*.md.packages/test-fixtures(GLSL → SPIR-V),examples/raytracing-showcase,runtime/streamlib-engine,sdk/vulkan-jpeg,vendor/tatolab-vulkanalia-vma.Cargo.tomledits are in non-member trees.packages/test-fixturesis the only member touched — it losesstreamlib.yamland 10 schema YAMLs, and keepsbuild.rs+shaders/, which is all itsinclude_bytes!(concat!(env!("OUT_DIR"), …))sites need.vendor/untouched, per the licensing rule.Test plan
cargo check --workspace --all-targetscargo test -p streamlib-test-fixtures --no-runcargo run -p xtask -- check-boundariesbash .claude/scripts/tests/ship-change-removed-gate.test.shNotes for owner
1. Titled
chore!deliberately. It deletes files frompackages/andexamples/, which are consumer trees — no engine behaviour changes and nothing in the wheel moves. The!marks that a consumer checkout loses files, not that any contract shifted.2. This does not port anything. It removes dead scaffolding so the port isn't reading around it. The remaining reason those trees don't compile is the identity grammar #1851 deleted, which is the signal you asked to keep.
3.
packages/screen-captureis now aCargo.toml, a generated crate root, and three_apple_impl_pending_files — no live processors at all. Deletion candidate, left out because that is a disposition call rather than dead-artifact removal.🤖 Generated with Claude Code