Report lost events at end of run#96
Open
ngorogiannis wants to merge 4 commits into
Open
Conversation
ngorogiannis
force-pushed
the
no-drop-log
branch
from
84c42af to
29a46b0
Compare
edwintorok
reviewed
Jul 7, 2026
|
|
||
| let lost_events ring_id num = | ||
| Printf.eprintf "[ring_id=%d] Lost %d events\n%!" ring_id num | ||
| let lost_events_count = ref 0 |
There was a problem hiding this comment.
Should this be an Atomic instead, or is it only ever accessed from one Domain?
Atomic.fetch_and_add would returns the old value, so at the cost of doing the sum twice we could detect the overflow and set a separate atomic flag that we've detected one.
Author
There was a problem hiding this comment.
This is only called on one domain. In fact, the callback API doesn't allow for callbacks in multiple domains currently.
edwintorok
approved these changes
Jul 9, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when events are lost a message is printed to stderr, which is flushed.
This can lead to more event loss, as it blocks the event loop.
We change to a simple counter that is printed at the end of the run if positive.
NB stacked on top of #95