feat: allow repeated --filter flags for exports - #443
Open
jacalata wants to merge 1 commit into
Open
Conversation
Previously `--filter` accepted only one value, and multi-pair filtering required joining pairs with '&' (e.g. `--filter "A=1&B=2"`). That parsing scheme conflicts with values that legitimately contain '&' (e.g. `Product Name=AT&T ...`). Make `--filter` repeatable via argparse action="append". Each flag now carries exactly one COLUMN=VALUE pair — no '&' splitting — so literal '&' in a value passes through untouched. Back-compat: when only one --filter flag is present, the value is still split on '&' so existing scripts keep working. Users who need '&' in a value should switch to the repeated-flag form. Adds parser tests for the new syntax and unit tests for apply_filters_from_args covering both forms. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for repeating --filter on the export command while preserving backward-compatible parsing of legacy &-joined filter pairs.
Changes:
- Update export CLI arg parsing to accept multiple
--filterflags (action="append"). - Implement back-compat filter splitting when a single
--filtercontains&. - Add/extend tests for parser behavior and filter application; update help text to document new usage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/parsers/test_parser_export.py | Adds tests validating --filter repeatability and default behavior. |
| tests/commands/test_datasources_and_workbooks_command.py | Adds unit tests for applying parsed filters into TSC request options, including back-compat. |
| tabcmd/locales/en/tabcmd_messages_en.properties | Expands the --filter help text to document the new repeatable flag semantics and back-compat. |
| tabcmd/commands/datasources_and_workbooks/export_command.py | Changes --filter arg to append and updates filter parsing logic accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+147
to
+159
| if not args.filter: | ||
| return | ||
| logger.debug("filter = {}".format(args.filter)) | ||
| # Back-compat: a single --filter flag historically joined multiple pairs | ||
| # with '&' (e.g. `--filter "a=1&b=2"`), so that one case still splits on '&'. | ||
| # Repeated --filter flags each carry exactly one pair — no split — so a | ||
| # literal '&' or '=' in a value is passed through untouched. | ||
| if len(args.filter) == 1: | ||
| values = args.filter[0].split("&") | ||
| else: | ||
| values = args.filter | ||
| for value in values: | ||
| ExportCommand.apply_filter_value(logger, request_options, value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--filterpreviously accepted a single value and required multi-pair filters to be joined with&, e.g.--filter "A=1&B=2". That parsing scheme prevents literal&inside a value (e.g.Product Name=AT&T 841000 PhonebecomesProduct Name=AT, then a bogusT 841000 Phoneclause).Make
--filterrepeatable viaargparseaction="append". Each flag now carries exactly oneCOLUMN=VALUEpair — no&splitting — so literal&in a value passes through untouched.Back-compat
When only one
--filterflag is present, the value is still split on&so existing scripts keep working:Verification
End-to-end against a live workbook with product names containing
&:--filter "Region=East" --filter "Product Name=AT&T 841000 Phone"AT&T 841000 Phone)--filter "Region=East&Product Name=Widget"(back-compat)Test plan
pytest tests/commands/test_datasources_and_workbooks_command.py tests/parsers/test_parser_export.py— 34 passed--filterwith&in the value returns the expected row&-joined form still parses and filters correctlyFollow-ups
Related work in flight:
=inside--filtervalues🤖 Generated with Claude Code