Skip to content

docs+fix: v0.9.1 final-check findings — CHANGELOG gaps, doc/log nits, review guardrail - #691

Merged
t0k0sh1 merged 1 commit into
mainfrom
fix/v091-final-check-findings
Aug 16, 2026
Merged

docs+fix: v0.9.1 final-check findings — CHANGELOG gaps, doc/log nits, review guardrail#691
t0k0sh1 merged 1 commit into
mainfrom
fix/v091-final-check-findings

Conversation

@t0k0sh1

@t0k0sh1 t0k0sh1 commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

v0.9.1 リリース前最終チェック(マイルストーン全44 issueの横断検証)で見つかった所見の一括修正。機能デグレはゼロで、所見はすべて CHANGELOG/doc/レビュー体制レベル。

GitHub側の対応(このPR外): follow-up issue #690 起票(PR #636 がフラグした cross_search_passages の span 非対称)、PR #645 本文の「issue paths unchanged」誤記載を訂正済み。

Test plan

  • cargo fmt --check — clean
  • cargo clippy --all-targets — clean
  • cargo test — full suite green (3,856 passed / 0 failed / 6 ignored)
  • Pre-PR diff-scoped mutation gate: 1 mutant, 1 unviable, 0 missed

https://claude.ai/code/session_01D9qnXBxou4stoxmacnDbKb

Summary by CodeRabbit

  • ドキュメント

    • 未リリース欄に、メトリクスや検索説明、コンパクション、エラー応答などの変更内容を追記しました。
    • メトリクス名と失敗時の記録例を最新仕様に更新しました。
    • Rustコード向けレビュー指示に、公開仕様と変更履歴の整合性確認を追加しました。
  • 改善

    • エラーメッセージのコンテキスト表示を整理し、構造化ログで確認しやすくしました。

… review guardrail

- CHANGELOG [Unreleased]: correct #623's "byte-identical" claim (the
  same PRs also changed the tag-count refusal to over_limit, added
  deny_unknown_fields to schema/audit, capped keyset cursors at 1032
  bytes, and moved a capacity race to stream_refusal), and record the
  seven public-contract changes the milestone shipped without entries:
  new /metrics series (#563/#616), compaction outcome fields (#586),
  explain's limit_to_reach_reason + contract repairs (#601), DELETE
  mid-rename 409 (#561), limit=0 floor on paged listings (#585/#676),
  restore exit-code contract + pre-manifest refusal (#616/#618/#619).
- src/registry.rs: embedding_failed's doc named a metric that does not
  exist (taguru_embed_refresh_total) — the real series is
  taguru_embedding_requests_total{operation="refresh"}.
- src/registry/engine.rs: three warn! sites used string interpolation
  for context/error while their siblings use structured fields; align.
- .coderabbit.yaml: add a review lens for public-contract changes
  missing or misdescribed in CHANGELOG's [Unreleased].

Claude-Session: https://claude.ai/code/session_01D9qnXBxou4stoxmacnDbKb
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 412aac4f-4f88-44d2-8cb0-d9c05270dbe8

📥 Commits

Reviewing files that changed from the base of the PR and between aa55544 and 50bade6.

📒 Files selected for processing (4)
  • .coderabbit.yaml
  • CHANGELOG.md
  • src/registry.rs
  • src/registry/engine.rs

Included review availability: 1 review is currently available. Based on recent review activity, included reviews refill at 2 per hour.


📝 Walkthrough

Walkthrough

公開契約の変更を CHANGELOG.md に記録し、レビュー指示を追加しました。メトリクス例を更新し、WAL とリカバリーフラッシュの警告を構造化ログに統一しました。

Changes

公開契約とログ記録

Layer / File(s) Summary
公開契約の記録とレビュー指示
.coderabbit.yaml, CHANGELOG.md
公開契約の変更を [Unreleased] に追加しました。レビュー指示に、変更内容との整合性を確認する項目を追加しました。
メトリクス例と構造化ログの更新
src/registry.rs, src/registry/engine.rs
埋め込みリフレッシュのメトリクス例を更新しました。WAL とリカバリーフラッシュの警告から重複したコンテキスト表示を削除しました。

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 50bad

This PR updates release documentation, corrects metric documentation and log formatting, and adds a review guardrail; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

  • t0k0sh1/taguru#572: src/registry/engine.rs の WAL 失敗処理とリカバリーログに関連します。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed タイトルはCHANGELOGの修正、ドキュメントとログの更新、レビューガードレールの追加という主要な変更を明確に示しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v091-final-check-findings

Comment @coderabbitai help to get the list of available commands.

@t0k0sh1
t0k0sh1 merged commit 48b5e62 into main Aug 16, 2026
15 checks passed
@t0k0sh1
t0k0sh1 deleted the fix/v091-final-check-findings branch August 16, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant