Skip to content

[Static SDK] Disable assertions in the Swift build. #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahmishal merged 2 commits into from
Aug 7, 2026
+1 −1
Merged

[Static SDK] Disable assertions in the Swift build. #557

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2de6d38
[Static SDK] Disable assertions in the Swift build.
al45tair May 22, 2026
3877f4c
Apply suggestion from @shahmishal
shahmishal Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions swift-ci/sdks/static-linux/scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ declare_package libarchive "libarchive" "BSD-2-Clause" "https://www.libarchive.o
declare_package mimalloc "mimalloc" "MIT" "https://microsoft.github.io/mimalloc/"

# Parse command line arguments
static_linux_sdk_version=0.1.0

@justice-adams-apple justice-adams-apple May 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ping me when this lands and I'll make sure the mainline CI job is updated to build the correct version

@shahmishal shahmishal May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop the version? It creates more work for no added value.

@FranzBusch FranzBusch May 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@al45tair al45tair May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It creates more work for no added value.

How are people to know whether (for instance) they've got a build of the Static SDK with this fix if we don't version it?

Equally, if we update the dependencies, how do they know they've got a version with the updated dependencies? (I guess for this they could check the SBOM, since we do have one).

We could drop the version from the filename maybe? That does make life harder for people though, if they care about some specific change we make, since Swift SDKs don't have a version field or any way to ask SwiftPM to tell you what version you have.

(Maybe that should be the ask? Add a version field to the Swift SDK support in SwiftPM, and list the version when you do swift sdk list?)

@al45tair al45tair May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we could update the CI script to look for a file with any version number as the output, and if it needs the version number for some reason then extract it from the filename?

static_linux_sdk_version=0.1.1
Comment thread
shahmishal marked this conversation as resolved.
Outdated
sdk_name=
archs=x86_64,aarch64
build_type=RelWithDebInfo
Expand Down Expand Up @@ -855,7 +855,7 @@ EOF

SWIFT_SOURCE_ROOT="${source_dir}/swift-project" \
SWIFT_BUILD_ROOT="${build_dir}/swift" \
run ${source_dir}/swift-project/swift/utils/build-script -r \
run ${source_dir}/swift-project/swift/utils/build-script -r -A \

@shahmishal shahmishal May 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a preset

@al45tair al45tair May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that, but then the build settings for the SDK are separate from the SDK's own build script, and then we have a versioning problem, since we could update the build settings and end up with a build of the Static SDK with the same version number as another build, but that's built with different build settings.

This wouldn't be a problem if the build scripts lived in the Swift repo rather than the swift-docker repo. Do we want to do that instead?

--reconfigure \
--compiler-vendor=apple \
--bootstrapping hosttools \
Expand Down
Loading