Repository navigation
Agents and Dex Web: UTC session IDs, Claude example base URL, Save connection label - #1651
Merged
Merged
Conversation
buildClaudeCliEnvironment kept only ANTHROPIC_API_KEY and the runtime variables, so a Worker that set ANTHROPIC_BASE_URL ran the Claude Code CLI against the default endpoint. Keep the same Anthropic settings as the Python example (KEPT_ANTHROPIC_SETTINGS).
…edentials A connector whose auth type is none, such as Hacker News, has no credentials to save, yet its form button said Save local credentials.
The Python CLI core formatted the session ID timestamp in local time, while the TypeScript CLI core uses UTC. Use UTC in Python, and check the shared shape <harness>-<UTC yyyymmdd-HHMMSS>-<6 hex> in both cores' new-session tests.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes found by the agent CLI end-to-end runs, one commit each:
<harness>-<UTC yyyymmdd-HHMMSS>-<6 hex>. Before, the same moment gavebuiltin-20261111-123014-3efeb4from Python (local time) andbuiltin-20261111-203123-…from TypeScript.ANTHROPIC_BASE_URLreaches the Claude Code CLI.buildClaudeCliEnvironmentin the Claude Agent SDK order-support example keepsANTHROPIC_BASE_URLwhen the Worker sets it, matching the Python example'sKEPT_ANTHROPIC_SETTINGS; other Anthropic and Claude sign-in settings still never reach the CLI.Why
The end-to-end check of every command and framework example (#1647) showed the time-zone mismatch, could not point the TypeScript Claude example at a mock or proxy endpoint, and the Connectors page asked to "Save local credentials" for a connector that has none.
Testing
GetFlowDefinitions; CI uses the current server).examples/typescript: build, typecheck, and the four agent-harness integration tests (20/20) against a localdexcli dev; the Claude test asserts the CLI environment holds exactlyANTHROPIC_API_KEYandANTHROPIC_BASE_URLamong Anthropic/Claude settings.cd web && NODE_OPTIONS=--no-experimental-webstorage npm run checkon Node 26: 808 tests; a new test covers auth type none, an omitted auth type, and an API-key connector.web/app/connectors/ConnectorsPage.tsx(two lines).