Repository navigation
server-zd: tighten the sourced history page comparison in the time travel simulation - #1364
Merged
Merged
Conversation
The sourced page comparison accepted any pair of matching errors, even for reads without a byte limit, and never required an error to be compared. It now accepts only HistoryEventTooLarge under a finite limit. Each checked run also reads its first event under a limit one byte below that event's response, which must reject it the same way locally and through the history source, and the coverage requires such rejections.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time_travel_targets.rsnow accepts an error only when both the local and the sourced read returnHistoryEventTooLargeunder a finite byte limit.Why
The re-review of #1348 found that
compare_pagesaccepted any matching errors, including errors on unlimited reads that must succeed.compared_history_page_errorswas also never required to be positive. Refs #1325.Testing
cargo test -p dexzd-simulation --test time_travel_targets: pass (5092 compared rejections, 93,777 pages compared, 19 pages ended by the byte limit).cargo fmt --all --checkandcargo clippy -p dexzd-simulation --all-targets -- -D warnings: pass.