Repository navigation
Remove the Temporal-based Go Server - #1059
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 29, 2026
This was referenced Nov 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The remaining modules no longer import the Go Server after #1058. SDK/examples CI now runs against server-zd (#1052), the server integration suite is an independent module (#1053), and push Workers have been removed from all SDKs (#1023–#1029). Keeping the retired server tree leaves obsolete build, generation, image publication, release, and CI paths behind.
Migration
Go Server users must deploy server-zd and run dex-web separately for the console, or use dexcli dev for local development. The Go Server binaries and the dex-server / dex-server-all-in-one images are no longer built or published from this repository. Existing release tags and published artifacts remain available for migration. The final Go Server release is
server/v1.25.0; the tagarchive/temporal-go-servermarks the lastmaincommit that contains the Go Server source.server-zd supports the PostgreSQL Attribute Store only. Cadence, Temporal-based server deployments, MySQL, MongoDB, Snowflake, and Databricks Attribute Stores, and push Workers are not supported. Use pull Workers. StartFlow returns
INVALID_ARGUMENTwhenflow_start_delay_seconds > 0orretry_policyis set (see #995 and #996); remove Flow start delay and Flow-level retry options before migrating. Redis Attribute Store sync for server-zd is tracked in #616. SDK APIs and the protobuf source are unchanged by this PR.Web and CLI release selection now watches all
sdk-go/**changes because both consume the extracted SDK packages. This intentionally includes SDK README and integration-test changes.Main continues publishing
superdurable/dex-web:latest; the unchangeddocker-image-web-release.ymlcontinues publishing versioned Web images onweb/v*releases. On origin/main, the deleteddocker-image-release.ymlpublished only Go Server and all-in-one images; it never published Dex Web.server-zd release packaging
Move the existing LICENSE.md, LEGACY_NOTICES.md and LICENSES/ files byte-for-byte into server-zd, and update only their copy paths in server-zd/Dockerfile and server-zd-binary-release.yml. Server-zd image names and binary/image publication behavior are unchanged.
Agent rules
Remove Temporal skill routing, interpreter component rules, server log-tag rules, Gin-specific API error handling, and the deleted config-directory exception. Retarget the applicable Go ordering, naming, pointer, dependency, error and testing rules to server-zd/integ/**/*.go in all three rule systems. Keep unrelated rules unchanged.
Review fixes
Restore the Web main image publisher and the historical
server/ | MITcutoff row in all eight affected notices, plus the legacy source-license policy entry. Correct the license-tool source path and contributor toolchain reference. Remove unused Docker log tooling and release-selection exclusions, complete the module table, synchronize rule test targets, and trigger server-zd image/binary smoke coverage for packaged license changes.Testing
Review follow-up verification:
make copyright-checkandmake release-tooling-test(13 tests) pass.make -C server-zd/integ compilepasses with both integration build-tag configurations.actionlint .github/workflows/*.ymlreports only the pre-existing skills-ci SC2129 warning;actionlint -ignore SC2129 .github/workflows/*.ymlpasses.docs/changed in the review follow-up, so its docs build was not repeated.Passed locally:
go test -exec /usr/bin/true ./...in all seven modules, workspace on and off; execute every package test outside external integration directories in both modes, plus the extracted binary-harness tests.DEX_SERVER_ZD_BINARY=/tmp/dex-cli-zd-release/dex-server-zd make -C sdk-go e2eTests(released server-zd v0.1.11): full Go SDK integration suite, Web scenarios, and real-server pull-worker tests.make -C server-zd/integ compile check-scripts;go vet ./...with workspace on/off and with/without attributestore_integration.make generated-code-checkusing protoc 35.1 and its bundled includes: no generated diff and no .proto changes.make copyright-check copyright-test rust-rules-check ci-runner-checkand the license migration integration test.make release-tooling-test(13 tests).cd docs && npm run check: typecheck, both locales, links/anchors, routes, redirects, canonical/robots/sitemap audit (168 indexable routes, 13 redirects).actionlint -ignore SC2129 .github/workflows/*.ymlpasses.Known baseline limitation: literal
go build ./...in examples/go fails in both workspace modes because integ/flow_smoke_helper.go references dexcliPath, examplesAPIURL, flowServiceAddress and other declarations from main_test.go. These files are unchanged; all test packages compile and production packages build in both modes. No tests or assertions were skipped or modified for this limitation.CI covers the complete extracted real-server suite, PostgreSQL Attribute Sync, remaining SDK/examples E2E suites, and image builds. No docker compose or external database stack was started locally.
Reference audit and follow-up
No active module, build, script, workflow, or product-doc snippet depends on the removed root server module. No docs/content or zh-Hans page imports or raw-loads server config/code, so product content is unchanged. No tracked CODEOWNERS, labeler, Dependabot, or Renovate config needs adjustment.
Intentional grep matches remain in:
Full grep classification and command are in the local removal report. No active root server path remains outside these intentional historical or unrelated matches. Product-doc migration and protocol cleanup remain separate follow-up PRs. The server-zd owner follow-up #1060 tracks replacing the stale Go Server fallback advice in attribute_store_config.rs with accurate PostgreSQL-only guidance. The existing documented
ci:fast-mergerequirement for Server Integration against server-zd is retained. Pre-existing Check Gate filter and main-ci-all dispatch gaps remain follow-up work.🤖 Generated with Claude Code