feat: configurable brand name defaulting to the application name - #95
Open
mikehins-fliip wants to merge 1 commit into
Open
mikehins-fliip wants to merge 1 commit into
mikehins-fliip wants to merge 1 commit into
Conversation
The route-explorer brand heading was hardcoded to "Nimbus". It now reads
nimbus.app_name, which falls back to config('app.name') when null so the
playground is badged with the host application.
- injected via window.Nimbus.appName and exposed through useConfigStore
- RouteExplorerBranding renders the configured name
Config stays env-free (larastan): app_name defaults to null and resolves in
the view.
Tests: app-name injection and fallback (backend), plus the branding component
and config store (frontend).
mikehins-fliip
force-pushed
the
feat/app-name
branch
from
July 9, 2026 03:07
9bf2f9f to
d81f54a
Compare
sunchayn
reviewed
Jul 9, 2026
Comment on lines
+27
to
+30
| */ | ||
|
|
||
| 'app_name' => null, | ||
|
|
Owner
There was a problem hiding this comment.
Could you add this to the user-guide wiki as well?
| ); | ||
|
|
||
| $config = \Illuminate\Support\Js::from([ | ||
| 'appName' => config('nimbus.app_name') ?: config('app.name', 'Nimbus'), |
Owner
There was a problem hiding this comment.
Let's fall back to Nimbus instead of the app name by default. It is standard to show the product name. Also, this adds a bit of visibility to the package by default.
So basically, giving the user an opt-in option to customize the branding.
Suggested change
| 'appName' => config('nimbus.app_name') ?: config('app.name', 'Nimbus'), | |
| 'appName' => config('nimbus.app_name', 'Nimbus'), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The route-explorer brand heading was hardcoded to "Nimbus". This makes it configurable and defaults it to the host application's name, so the playground is badged with the app it runs in.
What is included
Notes
Tests