Repository navigation
feat: upgrade Polkadot.js and align multisig UX with Subscan - #247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
升级后的多签应用需要适配当前 Polkadot.js 接口,并与 Subscan 的视觉和交互保持一致。本次将依赖升级、UI 调整和发布前发现的功能问题一起修复:例如,链上多签内部执行失败但外层 extrinsic 成功时,现在会显示失败,不再触发成功回调;三成员、阈值四或重复公钥配置会在保存前被拒绝。
变更
signAsync()返回的签名交易进行广播和事件匹配;处理订阅回调早于 unsubscribe 返回的情况。广播后 120 秒仍未确认时结束 loading 并提示先查链,不自动重发;事件解码失败或缺少执行结果不再静默完成。验证
npm run check:通过;16 项回归测试全部通过、零跳过,ESLint、TypeScript 和生产构建通过。尚需关注