Repository navigation
fix(build): scope root file inclusion to sdist target only - #231
Merged
Merged
Conversation
hatchling settings under the top-level [tool.hatch.build] table apply to both the sdist and wheel build targets unless overridden per target. Our `include` list (LICENSE, README.md, pyproject.toml, reqif/) lived at that shared level, so those three loose files were also being bundled into the wheel. Since a wheel is installed by unzipping its contents directly into site-packages, this meant `pip install reqif` dropped site-packages/LICENSE, site-packages/README.md, and site-packages/pyproject.toml at the top of site-packages, outside of the reqif/ package. Move the include list into [tool.hatch.build.targets.sdist] so it only affects the sdist. The wheel target now falls back to hatchling's default behavior of packaging just the reqif/ package, with license/readme metadata carried in the wheel's .dist-info instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hatchling settings under the top-level [tool.hatch.build] table apply to both the sdist and wheel build targets unless overridden per target. Our
includelist (LICENSE, README.md, pyproject.toml, reqif/) lived at that shared level, so those three loose files were also being bundled into the wheel.Since a wheel is installed by unzipping its contents directly into site-packages, this meant
pip install reqifdropped site-packages/LICENSE, site-packages/README.md, and site-packages/pyproject.toml at the top of site-packages, outside of the reqif/ package.Move the include list into [tool.hatch.build.targets.sdist] so it only affects the sdist. The wheel target now falls back to hatchling's default behavior of packaging just the reqif/ package, with license/readme metadata carried in the wheel's .dist-info instead.