Repository navigation
Upgrade to Electron 43 - #63
Merged
Merged
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s Electron version to align the npm dependency, native-module header download configuration (CMake), and CI build environment.
Changes:
- Bump
electrondevDependency from29.4.3to43.2.0. - Update CMake header-download version to
v43.2.0for the Electron/iojs headers source. - Update GitHub Actions build environment to use
ELECTRON_VERSION: v43.2.0,windows-2022,actions/setup-node@v4, and Node.js24.x.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates the Electron devDependency to 43.2.0. |
| CMakeLists.txt | Updates the (Electron/iojs) headers version used by the native-module build. |
| .github/workflows/build.yml | Updates CI to build against Electron v43.2.0 headers and modernizes the Windows runner and Node setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
9
to
+11
| SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL") | ||
| SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name") | ||
| SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version") | ||
| SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version") |
summeroff
approved these changes
Aug 25, 2026
aleksandr-voitenko
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.