Restrict Twitch VOD audio to common Twitch services - #1782
Merged
Merged
Conversation
Detach stale VOD encoders when restarting Simple and Advanced outputs. Add a reusable loopback RTMP receiver and regression coverage for destination isolation, VOD toggles, and retained-output restarts.
Reuse output setup, signal handling, and cleanup across VOD and Simple streaming tests. Keep scenario settings explicit and document resource ownership, with coverage for failed connections and incomplete media.
aleksandr-voitenko
changed the title
Reject and release pool reservations without a valid Twitch stream key, and require pool credentials for Dual Output retries. Report native stop errors and ensure failed tests release their secondary users and scenes and shut down OBS.
sandboxcoder
approved these changes
Sep 23, 2026
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Detach stale VOD encoders when restarting Simple and Advanced outputs. Add a reusable loopback RTMP receiver and regression coverage for destination isolation, VOD toggles, and retained-output restarts.
Motivation & Context
Custom RTMP destinations such as TikTok could incorrectly receive Twitch’s VOD audio track, preventing ingest in Dual Output setups. Retained outputs could also keep transmitting that track after VOD was disabled or the destination changed.
VOD eligibility previously relied on the service’s settings label, which custom destinations could inherit from Twitch because of how the front-end deals with settings. Outputs also retained their own reference to the VOD encoder across stop/start cycles.
Changes:
Code:
detaching stale tracks while preserving shared source audio routing.
Tests:
Types of changes