Add test failure screenshot option.

[michelinewu]

Capture a Screenshot of the App When an E2E Test Fails

Issues

Speed up debugging by recording what the app actually looked like at the moment of failure.

Fixes

Added saveFailureScreenshot() to test/helpers/webdriver/index.ts, called from afterEach.always right before the existing teardown stops the app — the last point at which the failing UI still exists. Opt-in via SLOBS_FAIL_SCREENSHOT_DIR, so a normal test run captures nothing and is unaffected. Files are named after the test title (kebab-cased, truncated to 80 chars). The capture is wrapped in try/catch and never throws, so a failed screenshot can't mask or replace the real test failure.

File(s) changed: test/helpers/webdriver/index.ts

Performance Implications

None on a normal test run — the function returns immediately unless SLOBS_FAIL_SCREENSHOT_DIR is set. When enabled, adds one screenshot capture per failing test, on the already-failing path.

[Copilot]

🟡 Changes recommended

The generated screenshot filename can become empty for non-ASCII test titles, producing paths like .png and risking confusing/overwritten artifacts.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an opt-in mechanism to capture the app’s UI state at the moment an AVA e2e test fails, to improve failure debugging without impacting normal test runs.

Changes:

• Introduces saveFailureScreenshot() gated by SLOBS_FAIL_SCREENSHOT_DIR.
• Hooks screenshot capture into test.afterEach.always before teardown stops the app.

File summaries

File	Description
test/helpers/webdriver/index.ts	Adds an opt-in failure-screenshot helper and calls it during afterEach.always before teardown.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[bundlemon]

BundleMon

Unchanged files (4)

Status	Path	Size	Limits
✅	renderer.(hash).js	10.54MB	-
✅	vendors~renderer.(hash).js	4.67MB	-
✅	updater.js	115.29KB	-
✅	guest-api.js	40.23KB	-

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[wesrupert]

+1 on current suggestion, otherwise LGTM

[Copilot]

🟡 Changes recommended

Resolve the filename collision, startup-hook coverage, and hook-title normalization issues.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (2)

test/helpers/webdriver/index.ts:492

• appIsRunning is only set after waitForLoader, onboarding, and the remaining startup steps complete. If one of those steps fails after Application.start() has already connected the WebDriver client, this condition is false and the failing test gets no screenshot even though the app UI is available. Gate on the initialized client (or mark the app running immediately after start) so startup-hook failures are covered too.

    if (!testPassed && appIsRunning) await saveFailureScreenshot(t);

test/helpers/webdriver/index.ts:232

• AVA supplies hook callbacks with a hook-qualified t.title; the existing beforeEach code strips beforeEach hook for at line 466, and test/screentest/screenshoter.ts:72 strips afterEach hook for . Using the raw title here therefore produces names such as aftereach-hook-for-... instead of the test title promised by this option. Strip the afterEach/afterEach.always hook prefix before normalizing.

    const parsedTitle = t.title

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite