common_messages_sv2: add protocol-version-mismatch SetupConnectionError error_code - #2287
Merged
plebhash merged 1 commit intoAug 11, 2026
Conversation
plebhash
changed the title
common_messages_sv2: add protocol-version-mismatch SetupConnectionError error_code
plebhash
force-pushed
the
2026-08-06-protocol-version-mismatch-error-code
branch
from
August 7, 2026 00:17
a8d76eb to
1e2ec24
Compare
bit-aloo
approved these changes
Aug 7, 2026
bit-aloo
left a comment
bit-aloo
left a comment
Member
There was a problem hiding this comment.
Ah!! we never really checked for it. Makes sense.
GitGab19
approved these changes
Aug 7, 2026
plebhash
force-pushed
the
2026-08-06-protocol-version-mismatch-error-code
branch
from
August 8, 2026 00:41
1e2ec24 to
505a34b
Compare
…rror code Per SV2 spec, servers must respond to SetupConnection with a SetupConnectionError when they cannot support any protocol version in the client's requested [min_version, max_version] range.
plebhash
force-pushed
the
2026-08-06-protocol-version-mismatch-error-code
branch
from
August 11, 2026 19:14
505a34b to
6b5130e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion stratum-mining/sv2-apps#695