Repository navigation
Conversation
On Wayland, every other app's audio output is linked to the virtual sink. When Stoat quits, the sink is removed while those links still exist, so WirePlumber's linking.pause-playback pauses their media players as if their output device had been unplugged. Remove the links to the virtual sink before quitting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thank you for your contribution and your investigation. I have been meaning to investigate this bug myself. Please note that we won't be able to merge this for two reasons:
I will be opening an issue and fixing this issue in node-pipewire myself, and I will tag you there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux Wayland, quitting Stoat pauses whatever else is playing (music players, browser videos).
initVirtualMiclinks every other app's audio output tostoat-virtual-sink. When Stoat quits, the sink is removed while those links still exist, and WirePlumber'slinking.pause-playback(on by default) pauses the MPRIS players of the apps that were linked to it, the same way it does when headphones are unplugged. WirePlumber's own log for this is "node removed: pausing linked media player".This removes the links to the virtual sink on
will-quit, waits briefly for PipeWire to process that, then quits.Fixes #334 (closed by the reporter, but it still happens on 1.5.4)
Testing: dev build on Fedora KDE Wayland (WirePlumber 0.5.17), with High Tide playing and linked to the virtual sink, quitting Stoat twice on each build:
🤖 Generated with Claude Code