Grade 5'/3' bias symmetrically via abs(log2) distance - #16
Open
rmillikin wants to merge 1 commit into
Open
Conversation
The report card previously penalized only low 5'/3' bias values (3' enrichment), treating a 5' enrichment of 2.0 as GOOD. Since the metric is a ratio, a value and its reciprocal represent the same magnitude of coverage non-uniformity. Grade it on the symmetric log2 distance from the ideal 1.0 instead, so both directions are penalized equally: >1.32 fail (raw <0.40 or >2.50), >1.00 warn (<0.50 or >2.00), >0.30 ok (<0.81 or >1.23), else good (0.81-1.23). The low-side thresholds reproduce the previous edges, so the degradation direction grades as before. A per-metric grade_fn decouples the graded/ drawn quantity from the displayed value, which still shows the raw ratio. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GAnubcGrQV293bp3d7knvF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report card previously penalized only low 5'/3' bias values (3' enrichment), treating a 5' enrichment of 2.0 as GOOD. Since the metric is a ratio, a value and its reciprocal represent the same magnitude of coverage non-uniformity. Grade it on the symmetric log2 distance from the ideal 1.0 instead, so both directions are penalized equally:
The low-side thresholds reproduce the previous edges, so the degradation direction grades as before. A per-metric grade_fn decouples the graded/ drawn quantity from the displayed value, which still shows the raw ratio.
Claude-Session: https://claude.ai/code/session_01GAnubcGrQV293bp3d7knvF