Skip to content

Duplicate admin order confirmation email sent upon "Re-send order email" #342

Description

@petedermott

If a user has completed an order they are presented with a page that gives them the opportunity to "Re-send order email" (the /checkout/complete url)

If the site has a settings.SHOP_ORDER_EMAIL_BCC variable set then this second email will also be sent to the admin (https://github.com/stephenmcd/cartridge/blob/master/cartridge/shop/checkout.py#L182) which could potentially cause confusion for the shop owners as they may think they have duplicate orders.

We could potentially just duplicate the send_order_email function as a "send_admin_order_email" function and call that once in the order view (https://github.com/stephenmcd/cartridge/blob/master/cartridge/shop/checkout.py#L182) and remove the BCC when the customers email is called but I would be interested to know if people thought this is the optimum path.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions