Repository navigation
ci: release from master only, retire develop - #343
Merged
Merged
Conversation
Drop the develop branch from the PR and release workflows and remove the publish:next script; master is now the only long-lived branch and publishes to npm `latest`. Document the release flow in the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently retire develop publishing while preserving the existing master release process, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Simplifies releases to use only master, eliminating the parallel develop → next publishing path that required extra version bumps during promotions.
Changes:
- Restricts release and PR workflows to
master. - Removes the
publish:nextscript and develop release step. - Documents the changeset-based release process.
| File | Description |
|---|---|
| README.md | Documents contributions and releases through master. |
| package.json | Removes the publish:next script. |
| .github/workflows/release.yml | Removes develop-triggered releases. |
| .github/workflows/pr.yml | Limits PR CI to PRs targeting master. |
Review effort: Balanced
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From now on,
masteris the only long-lived branch.develophas been retired.Running
develop→ npmnextalongsidemaster→latestmeant every promotion needed a fresh version bump: versions published tonextcan never be published again. That's the workaround #319, #340 and #342 needed.Changes
release.yml: only triggers onmaster. The "Create Develop Release" step is removed.pr.yml: PR CI only runs for PRs targetingmaster.package.json: thepublish:nextscript is removed.README.md: new "Releasing" section. Open PRs againstmaster, add a changeset, then merge the version bump PR to publish tolatest.No published package changes, so this has no changeset.
State at the time of this PR
developandmasterhave identical trees after chore: merge master back into develop after 6.1.1 #342.developis master plus one merge commit, so deleting it loses nothing.develop.nextmatcheslateston all seven packages: 6.1.1 for discovery, wallets, virtual-wallet and wallet-standard, and 6.1.0 for core, modal and ui.After merge (repo admin)
developbranch.developmentbranch ruleset targetsrefs/heads/development, which doesn't exist, so it never protecteddevelop. It can be deleted.nextstops moving after this, so it will fall behindlateston the next release. Either remove it (npm dist-tag rm <pkg> next) or add a manual snapshot workflow later if pre-releases are needed.Test plan
package.jsonis validpnpm format:check🤖 Generated with Claude Code