Skip to content

fix(event): support both positional and object args in parse() #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateussiqueira wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

fix(event): support both positional and object args in parse() #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion sdk/event/event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ exports.update = async function (id, {isDelivered, user} = {}) {
return rest.patchId(resource, id, payload, user);
};

exports.parse = async function ({content, signature, user} = {}) {
exports.parse = async function (content, signature, user) {
/**
*
* Create single notification Event from a content string
Expand All @@ -189,6 +189,17 @@ exports.parse = async function ({content, signature, user} = {}) {
*
*/

if (typeof content === 'object' && content !== null && !Array.isArray(content)) {
({content, signature, user} = content);
}

if (typeof content !== 'string' || content.length === 0) {
throw new Error('content must be a non-empty JSON string');
}
if (typeof signature !== 'string' || signature.length === 0) {
throw new Error('signature must be a non-empty base-64 string');
}

let event = Object.assign(new Event(), JSON.parse(content)['event']);
try {
signature = Ellipticcurve.Signature.fromBase64(signature);
Expand Down