Repository navigation
Adjust code coverage to only occur on a CRON schedule daily - #7720
Merged
Merged
Conversation
dhaney-stacks
requested review from
aaronb-stacks,
brice-stacks and
hstove-stacks
October 9, 2026 16:39
hstove-stacks
previously approved these changes
Oct 9, 2026
hstove-stacks
left a comment
hstove-stacks
left a comment
Contributor
There was a problem hiding this comment.
great to see it's such an easy change!
brice-stacks
reviewed
Oct 9, 2026
brice-stacks
left a comment
brice-stacks
left a comment
Contributor
There was a problem hiding this comment.
This looks mostly good, but I had a few comments for improvements. We also could update the build flags for the regular runs so that they no longer run with code coverage. I think that would touch more places, so it's fine if you want to do that in a separate PR.
aaronb-stacks
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust code coverage to only occur on a CRON schedule daily. We want accurate code coverage to be reported (and badged on our repo README), but we don't need to run it every PR or merge. It adds 4 minutes to the CI pipeline and we never take any action based on the results.
Applicable issues
N/A
Additional info (benefits, drawbacks, caveats)
N/A
Checklist
N/A