[jerm-dro]

Summary

• Why: Support Pi in LLM gateway setup #6818 made thv llm setup write Pi's models.json under $PI_CODING_AGENT_DIR, but Pi's MCP config (mcp.json), global skills directory, and install detection still hardcoded ~/.pi/agent. A user with the variable set got gateway config in their custom directory while MCP servers and skills landed in the default one (review comment).
• What:
  • Add a declarative ConfigDirEnvVar field to clientAppConfig and set it to PI_CODING_AGENT_DIR on the Pi entry, replacing the Pi-specific ClientType check in buildLLMSettingsPath.
  • Resolve the override in one helper (configDirOverride, keeping the existing ~ and relative-path handling) and route every Pi path through it: MCP config (register, create, GetConfigPath via a new buildMCPConfigPath), IsClientInstalled, global skills (<dir>/skills/<name>), and LLM settings.

Type of change

• Bug fix

Test plan

• Unit tests (task test)
• Linting (task lint-fix)

Ran the pkg/client and pkg/skills unit tests directly (go test -race), not the full task test suite. Added TestPiAgentDirOverrideAppliesToMCPAndSkills, which failed before the fix (mcp.json resolved under ~/.pi/agent) and passes after.

Does this introduce a user-facing change?

Yes, for Pi users who set PI_CODING_AGENT_DIR:

• Before: thv client register pi wrote ~/.pi/agent/mcp.json, thv skill install (user scope) wrote to ~/.pi/agent/skills/, and Pi counted as installed only if ~/.pi/agent existed, even though thv llm setup used $PI_CODING_AGENT_DIR/models.json.
• After: all of these resolve under $PI_CODING_AGENT_DIR. Users without the variable see no change.

Special notes for reviewers

• Existing MCP registrations or skills already written to ~/.pi/agent for users with the variable set are not migrated; they will need to re-register.
• Assumes Pi (and its MCP adapter) reads mcp.json and skills from PI_CODING_AGENT_DIR, per the review comment; not independently verified against Pi.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.68%. Comparing base (9732005) to head (265772d).

Files with missing lines	Patch %	Lines
pkg/client/config.go	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6839      +/-   ##
==========================================
- Coverage   79.71%   79.68%   -0.04%     
==========================================
  Files         817      817              
  Lines       83411    83421      +10     
==========================================
- Hits        66492    66473      -19     
- Misses      16914    16943      +29     
  Partials        5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.