ci: multi-arch dev images + dev- tag prefix - #124
Draft
oleg-ssvlabs wants to merge 1 commit into
Draft
Conversation
Two follow-ups to the manual dev-release job (#123): - Build both linux/amd64 and linux/arm64 for pushed dev images, matching the release path. amd-only was inherited from the PR build-check job (where single-arch is intentional for speed); a deployable dev image has no reason to be restricted. Achieved by dropping image-architectures so docker.yml's default (both arches) applies, exactly like the main workflow. - Default the dev image tag to 'dev-<sha>' so it is self-evidently a non-release build, following the prefix convention used by common tooling (sha-, pr-). A custom `tag` input still overrides it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to the manual dev-release job added in #123.
Changes
linux/amd64andlinux/arm64, matching the release path. It was amd-only only because that line was inherited from the PR build-check job (where single-arch is intentional — that job just validates the build and pushes nothing, so building arm under emulation would double PR CI time for no benefit). A deployable dev image has no reason to be restricted. Done by droppingimage-architecturessodocker.yml's default (linux/amd64,linux/arm64) applies — exactly how themainworkflow'sdocker-build-pushgets multi-arch.dev-tag prefix. Default dev tag is nowdev-<sha>instead of a bare<sha>, so it's self-evidently a non-release build. Follows the prefix convention used bydocker/metadata-action(sha-,pr-). The customtaginput still overrides it.Tag convention notes
No single mandated standard exists; the recognized signals are SemVer pre-release suffixes (
-dev/-rc/-alpha, needs a version base), moving channel words (edge/nightly/dev), or prefixed immutable tags (sha-/pr-). For an immutable per-commit deployable image, adev-prefix on the SHA is the cleanest fit: explicit, reproducible, and groups dev tags together in ghcr.dev-<sha>) chosen over suffix (<sha>-dev) as the more common marker style; trivial to flip if you prefer the suffix.dev-<short-sha>, that's a small step/job add.The whole change is 2 lines in
workflow-feature.yml;docker.ymlis untouched. Left as draft for your review.🤖 Generated with Claude Code