Add unsigned numbers extensions.#1779
Merged
Merged
Conversation
Contributor
Author
|
Sorry I forgot to run |
MohammedKHC
commented
Feb 12, 2026
Comment on lines
+54
to
+60
| public static final fun writeUByte-EK-6454 (Lokio/BufferedSink;B)Lokio/BufferedSink; | ||
| public static final fun writeUInt-Qn1smSk (Lokio/BufferedSink;I)Lokio/BufferedSink; | ||
| public static final fun writeUIntLe-Qn1smSk (Lokio/BufferedSink;I)Lokio/BufferedSink; | ||
| public static final fun writeULong-2TYgG_w (Lokio/BufferedSink;J)Lokio/BufferedSink; | ||
| public static final fun writeULongLe-2TYgG_w (Lokio/BufferedSink;J)Lokio/BufferedSink; | ||
| public static final fun writeUShort-i8woANY (Lokio/BufferedSink;S)Lokio/BufferedSink; | ||
| public static final fun writeUShortLe-i8woANY (Lokio/BufferedSink;S)Lokio/BufferedSink; |
Contributor
Author
There was a problem hiding this comment.
Should we use @JvmName for these methods??
I don't think that the api should contain this..
Or is this alright??
Contributor
Author
There was a problem hiding this comment.
The mangling seems to be stable
https://kotlinlang.org/docs/inline-classes.html#mangling
functions using inline classes are mangled by adding some stable hashcode to the function name.
Collaborator
There was a problem hiding this comment.
The whole type is already invisible to Java due to the hyphen. Otherwise this is public API we have to track.
Co-authored-by: Brian Norman <brian_norman@atavium.com>
swankjesse
approved these changes
Jun 18, 2026
| } | ||
|
|
||
| /** | ||
| * Writes a big-endian, unsigned int to this sink using four bytes. |
Collaborator
There was a problem hiding this comment.
These docs are perfect
Co-authored-by: Jesse Wilson <jesse@swank.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #513