Skip to content

Fix: charge_limit and reserve dummy sensors incorrectly use device_class=battery #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 4 commits into from
Jul 19, 2026
+5 −3
Merged

Fix: charge_limit and reserve dummy sensors incorrectly use device_class=battery #4271

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64cc8f6
Initial plan
Copilot Jul 18, 2026
34a12c3
Fix: Remove device_class=battery from charge_limit and reserve sensor…
Copilot Jul 18, 2026
b8782af
Potential fix for pull request finding
springfall2008 Jul 19, 2026
fa1cb2a
Fix indentation in create_entity method
springfall2008 Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/predbat/inverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,11 +522,11 @@ def __init__(self, base, id=0, quiet=False, rest_postCommand=None, rest_getData=

if not self.inv_has_reserve_soc:
self.create_missing_arg("reserve", self.reserve)
self.base.args["reserve"][id] = self.create_entity("reserve", self.reserve, device_class="battery", uom="%")
self.base.args["reserve"][id] = self.create_entity("reserve", self.reserve, device_class=None, uom="%", icon="mdi:battery-lock")

if not self.inv_has_target_soc:
self.create_missing_arg("charge_limit", 100)
self.base.args["charge_limit"][id] = self.create_entity("charge_limit", 100, device_class="battery", uom="%")
self.base.args["charge_limit"][id] = self.create_entity("charge_limit", 100, device_class=None, uom="%", icon="mdi:target")

if self.inv_output_charge_control != "power":
max_charge = self.battery_rate_max_charge * MINUTE_WATT
Expand Down Expand Up @@ -1308,7 +1308,7 @@ def find_charge_curve(self, discharge):
self.log("Warn: Cannot find battery {} curve (settings missing), one of the required settings for {}, {}_rate and battery_power are missing from apps.yaml".format(curve_type, soc_label, curve_type))
return {}

def create_entity(self, entity_name, value, uom=None, device_class="None"):
def create_entity(self, entity_name, value, uom=None, device_class=None, icon=None):
"""
Create dummy entities required by non GE inverters to mimic GE behaviour
"""
Expand All @@ -1322,6 +1322,8 @@ def create_entity(self, entity_name, value, uom=None, device_class="None"):
attributes["unit_of_measurement"] = uom
if device_class is not None:
attributes["device_class"] = device_class
if icon is not None:
attributes["icon"] = icon

self.created_attributes[entity_id] = attributes

Expand Down
Loading