Context refresh fails on reactive Cloud Foundry when using Actuator without spring-boot-health#50916
Open
dlwldnjs1009 wants to merge 1 commit into
Open
Conversation
Move the reactive Cloud Foundry health endpoint extension into a health-specific configuration guarded by @ConditionalOnClass. When spring-boot-health is absent, scanning the outer configuration attempts to resolve ReactiveHealthEndpointWebExtension and causes context refresh to fail. Signed-off-by: Lee JiWon <dlwldnjs1009@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #50857, which fixed the servlet Cloud Foundry actuator
auto-configuration. #50794 noted
CloudFoundryReactiveActuatorAutoConfigurationas an unverified sibling.This PR confirms the reactive sibling with a failing test. When
spring-boot-healthis absent, parsing the reactive Cloud Foundry actuatorconfiguration resolves
ReactiveHealthEndpointWebExtensionfrom the health@Beanmethod signature, causing context refresh to fail before/cloudfoundryapplicationcan be registered.Changes
cloudFoundryReactiveHealthEndpointWebExtensioninto a nestedHealthConfigurationguarded by@ConditionalOnClass(HealthEndpoint.class)Testing
CloudFoundryReactiveActuatorAutoConfigurationTests.refreshSucceedsWithoutHealth(new; fails before this change)CloudFoundryReactiveActuatorAutoConfigurationTestsandCloudFoundryActuatorAutoConfigurationTestspass