Skip to content

Fix zero task limit for reverse ranges #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
winklemad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix zero task limit for reverse ranges #3444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion luigi/tools/range.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def requires(self):
self._emit_metrics(missing_datetimes, finite_start, finite_stop)

if self.reverse:
required_datetimes = missing_datetimes[-self.task_limit :]
required_datetimes = missing_datetimes[-self.task_limit :] if self.task_limit else []
else:
required_datetimes = missing_datetimes[: self.task_limit]
if required_datetimes:
Expand Down
16 changes: 16 additions & 0 deletions test/range_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,22 @@ def test_start_long_before_long_days_back_and_with_long_days_forward(self):
},
)

def test_reverse_with_zero_task_limit_requires_no_tasks(self):
class RangeDailyDerived(RangeDailyBase):
def missing_datetimes(self, finite_datetimes):
return finite_datetimes

task = RangeDailyDerived(
of=CommonDateTask,
now=datetime_to_epoch(datetime.datetime(2016, 1, 4)),
start=datetime.date(2016, 1, 1),
stop=datetime.date(2016, 1, 4),
task_limit=0,
reverse=True,
)

self.assertEqual(task.requires(), [])


class RangeHourlyBaseTest(unittest.TestCase):
maxDiff = None
Expand Down
Loading