Skip to content

spin add: remove trigger compatibility check #3626

Description

@itowlson

#2027 reinstated a check in spin add that the component being added had the same trigger type as the current ones. This was correct at the time because we then supported only a single trigger type in an app. However, time moves on (spoilers), and an app can now cheerfully (well, moderately cheerfully) have more than one trigger type. So we should remove the check.

Thanks @michelleN for spotting that the check was still there! (I thought I had removed it when we did multi-trigger-type, but I guess that was just a beautiful dream.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions