Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe popover overlay tests now cover tooltip interactions in nested popovers. They check Escape dismissal with visible or hidden tooltips and verify that nested popovers close from the inner popover outward. ChangesPopover tooltip Escape behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The new tests cover Escape dismissal with tooltips and nested popovers; no merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The test-only change appears safe to merge, with a non-blocking import-boundary cleanup recommended. Findings
|
a499688 to
72aa3e4
Compare
What does this PR do?
Adds browser regression coverage for Escape dismissal when a popover contains tooltips, as reported in #1663:
These cases already pass on current
main(0e05db585). The current tooltip uses CDKOverlaydirectly and does not enterBrnOverlayService's private stack. CDK skips overlays without keydown subscribers when dispatching keyboard events. This PR records the expected integration behavior without changing production dismissal logic or claiming to reproduce the reported failure on current code.Related: #1663.
PR Checklist
PR Type
Which package are you modifying?
Validation
pnpm install --frozen-lockfilepnpm exec vitest run --config libs/helm/vite.config.mts— all 119 tests in 33 files pass in Chromium, including the three new cases.pnpm exec eslint libs/helm/popover/src/lib/hlm-popover-overlay.spec.tspnpm exec prettier --check libs/helm/popover/src/lib/hlm-popover-overlay.spec.tsgit diff --checkDoes this PR introduce a breaking change?
Summary by CodeRabbit