Repository navigation
Conversation
Dense rows are inset, rounded and separated by a hairline gap of background instead of a drawn divider, and they sit on surfaceContainerLow - the same theme role ElevatedCard uses for its container - so a super compact row matches the compact card tone. The first row is rounder, and only on its top corners: it is the entry the eye lands on, and rounding its bottom too would lift it out of the run. Read entries are also dimmed a little further so the difference is legible at a glance in a dense list. Spacings: 2 dp row gap, row inset at half the page margin, 5 dp corner radius and 15 dp for the first row.
Owner
|
I'm not sure. I'd really like to hear from people that actually use these styles (I don't) what they prefer. Seems to me that this just adds extra whitespace which is kind of the opposite of the intention of these styles |
The colour behind a swiped row was painted full-bleed under the row surface. A clip antialiases each draw inside it rather than the flattened result, so colour beneath the row still tinted the partially-covered corner pixels, leaving a hairline tracing the arcs. Dense rows now paint the colour only in the strip the row has vacated. Card styles keep the full-bleed background, since their elevated container occludes it at rest. The row outline is also extracted into a single itemShape so it is authored once, by the item root's clip, instead of being reproduced by the content as well.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dense rows are inset, rounded and separated by a hairline gap of background instead of a drawn divider, and they sit on surfaceContainerLow - the same theme role ElevatedCard uses for its container - so a super compact row matches the compact card tone.
The first row is rounder, and only on its top corners: it is the entry the eye lands on, and rounding its bottom too would lift it out of the run.
Read entries are also dimmed a little further so the difference is legible at a glance in a dense list.
Spacings: 2 dp row gap, row inset at half the page margin, 5 dp corner radius and 15 dp for the first row.
What does this change?
Checklist
./gradlew ktlintFormatand committed the resultMIGRATION_N_N+1inAppDatabase.ktapp/src/androidTest/.../db/room/Screenshots (if UI change)
Before (with refresh fix):
https://github.com/user-attachments/assets/c66ee528-d8a7-46e6-9383-53beab83caca
After:
https://github.com/user-attachments/assets/af91974e-0ac5-4d23-b336-2f78aa7497ed