Migrate shared/* packages to Vitest - #101
Conversation
Move connections, constants, database, schemas, and utils onto Vitest+node projects in the root workspace so shared package runners stay decoupled from apps/cli's Bun runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (32)
📝 WalkthroughWalkthroughFive shared packages migrate their tests from Bun to Vitest with Node-based package configs. Their scripts and dependencies are updated, root Vitest project registration is expanded, and one asynchronous peer test gains a microtask flush helper. ChangesShared Vitest migration
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
shared/connections,constants,database,schemas, andutilstests from Bun to Vitest+nodeapps/clion Bun unchanged; package test-runner choice stays decoupled from consumersCloses #91
Test plan
bun -F @cyrus/{connections,constants,database,schemas,utils} test:unitpasses under Vitestbun -F @cyrus/database test:integrationpasses under Vitestbunx vitest runfrom repo root includes all five packages and passesbun:testimports remain in these five packagesbun -F @cyrus/cli test:unitstill passes on BunMade with Cursor
Summary by CodeRabbit