Repository navigation
transformers: bound an attention mask by its known And factor - #3012
Merged
Merged
Conversation
A band mask ANDed with a padding mask built from a runtime length has no uniform_tdim, so ScaledMaskedSoftmax planted no ROI on the scores and the rel-pos attention could not be blockified for pulsing. input_roi now uses an upper bound of the mask: its uniform_tdim, or the known factors of an And, followed through axis ops and casts.
|
Reference: 2026-10-13 morning nightly run (0d old) · full report → run Speed — evaltime · prefill · decode no inference-speed regressions
|
| Δ | metric | device | main → PR |
|---|---|---|---|
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load · cpu |
apple-m1-max |
3.44 s → 4.32 s | |
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load · metal |
apple-m1-max |
3.44 s → 4.32 s | |
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load · cpu_mt |
apple-m1-max |
3.45 s → 4.32 s | |
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load+optimize · metal |
apple-m1-max |
3.63 s → 4.5 s | |
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load+optimize · cpu |
apple-m1-max |
3.87 s → 4.76 s | |
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load · cuda |
i9-11900kb_rtx-4060 |
4.73 s → 5.82 s | |
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load+optimize · cpu_mt |
apple-m1-max |
3.89 s → 4.75 s | |
| nemotron_3_5_asr_streaming_0_6b_f32f32_encoder_1s load+optimize · cuda |
i9-11900kb_rtx-4060 |
5.47 s → 6.57 s | |
| hey_snips_v1 load · 400ms |
cortex-a7 |
63 ms → 70 ms | |
| en_tdnn_lstm_bn_q7 RSS @ load · pulse_240ms |
cortex-a53 |
25.1 MB → 26.7 MB | |
| en_tdnn_8M RSS @ ready · 2600ms |
cortex-a55 |
63.8 MB → 67.2 MB | |
| en_tdnn_8M load · pulse_180ms |
cortex-a55 |
982 ms → 1.03 s | |
| en_tdnn_8M load+optimize · pulse_180ms |
cortex-a55 |
1.12 s → 1.18 s |
Bench numbers come from shared CI hardware and do produce false positives: a flagged
row is not on its own evidence of a real regression, and a clean report is not proof
there is none. Contributors do not need to chase what is reported here — leave the
reading of it to the maintainers, who will say if something needs action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A band mask ANDed with a padding mask built from a runtime length has no uniform_tdim, so ScaledMaskedSoftmax planted no ROI on the scores and the rel-pos attention could not be blockified for pulsing. input_roi now uses an upper bound of the mask: its uniform_tdim, or the known factors of an And, followed through axis ops and casts.