Conversation
|
Do you expect it to send the authorization url when the |
The resolve endpoint sends back a setup_url which the action can send as a comment for the linking process |
| # GitHub | ||
| GITHUB_OIDC_AUDIENCE= |
There was a problem hiding this comment.
This should be removed. If ever being planned to be used on our Go-backend, it should be dynamically loaded from GitHub environmental variables (secrets), as we can't load any variables from .env dynamically in action.yml, but still want to avoid duplicating the same values.
There was a problem hiding this comment.
yeah i mean technically a secrets manager would be used to load secrets.
There was a problem hiding this comment.
Replace it with dynamic loading and mark this solved.
There was a problem hiding this comment.
Uhh actually the aud is anyway present in the jwt token under the aud field i believe so this aint really a secret, although we do have to do this secrets manager for stuff like postgres password and discord client secret etc.
there is no |
Summary
Type of change
Checklist